Bug 55549

Summary: Remove efl port style exception of Webcore/JavaScriptCore
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, tkent, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
tkent: review+, gyuyoung.kim: commit-queue-
Patch none

Gyuyoung Kim
Reported 2011-03-01 20:26:53 PST
As mentioned in Bug 55292 comment #3, WebCore and JavaScriptCore need to adhere WebKit coding style.
Attachments
Patch (1.18 KB, patch)
2011-03-01 20:28 PST, Gyuyoung Kim 		tkent: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch (1.21 KB, patch)
2011-03-01 20:37 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-03-01 20:28:47 PST
Created attachment 84360 [details] Patch
WebKit Review Bot
Comment 2 2011-03-01 20:30:53 PST
Attachment 84360 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 52, in <module> import webkitpy.style.checker as checker File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 172 "-readability/parameter_name"]), ^ SyntaxError: invalid syntax If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 3 2011-03-01 20:33:21 PST
Comment on attachment 84360 [details] Patch Looks good.
Gyuyoung Kim
Comment 4 2011-03-01 20:35:26 PST
Comment on attachment 84360 [details] Patch There is a syntax problem. I'm going to upload new patch soon with your name.
Gyuyoung Kim
Comment 5 2011-03-01 20:37:41 PST
Created attachment 84361 [details] Patch I fix style error.
WebKit Commit Bot
Comment 6 2011-03-01 22:29:07 PST
Comment on attachment 84361 [details] Patch Clearing flags on attachment: 84361 Committed r80095: <http://trac.webkit.org/changeset/80095>
Note You need to log in before you can comment on or make changes to this bug.