Bug 55549

Summary: Remove efl port style exception of Webcore/JavaScriptCore
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, tkent, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
tkent: review+, gyuyoung.kim: commit-queue-
Patch none

Description Gyuyoung Kim 2011-03-01 20:26:53 PST 
As mentioned in Bug 55292 comment #3, WebCore and JavaScriptCore need to adhere WebKit coding style.
Comment 1 Gyuyoung Kim 2011-03-01 20:28:47 PST 
Created attachment 84360 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-01 20:30:53 PST 
Attachment 84360 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 52, in <module>
    import webkitpy.style.checker as checker
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 172
    "-readability/parameter_name"]),
                                  ^
SyntaxError: invalid syntax


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2011-03-01 20:33:21 PST 
Comment on attachment 84360 [details]
Patch

Looks good.
Comment 4 Gyuyoung Kim 2011-03-01 20:35:26 PST 
Comment on attachment 84360 [details]
Patch

There is a syntax problem. I'm going to upload new patch soon with your name.
Comment 5 Gyuyoung Kim 2011-03-01 20:37:41 PST 
Created attachment 84361 [details]
Patch

I fix style error.
Comment 6 WebKit Commit Bot 2011-03-01 22:29:07 PST 
Comment on attachment 84361 [details]
Patch

Clearing flags on attachment: 84361

Committed r80095: <http://trac.webkit.org/changeset/80095>