| Summary: | JavaScriptCore GYP build should copy some headers into the target framework | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 55018 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-03-01 16:27:01 PST
Created attachment 84321 [details]
Patch
Comment on attachment 84321 [details]
Patch
Yeah, I'm not a big fan here. Seems like we should have a separate (identical) list of "private" and "public" headers in the gypi. You could no longer auto-gen this gypi list from the file system for example.
But I think these are also things we can make better decisions on as we get further in this process.
My understanding is that the prolific private headers are only required because of the ForwardingHeaders design. Once we change the Apple-internal submission script to submit the Source directory instead of the individual frameworks, then I suspect we'll be able to remove most (if not all) of the private headers. The commit-queue encountered the following flaky tests while processing attachment 84321 [details]: inspector/debugger/debugger-breakpoints-not-activated-on-reload.html bug 55551 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 84321 [details] Patch Clearing flags on attachment: 84321 Committed r80094: <http://trac.webkit.org/changeset/80094> All reviewed patches have been landed. Closing bug. |