Bug 55524

Summary: JavaScriptCore GYP build should copy some headers into the target framework
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-03-01 16:27:01 PST
JavaScriptCore GYP build should copy some headers into the target framework
Attachments
Patch (32.40 KB, patch)
2011-03-01 16:29 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-01 16:29:25 PST
Created attachment 84321 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-01 16:42:16 PST
Comment on attachment 84321 [details] Patch Yeah, I'm not a big fan here. Seems like we should have a separate (identical) list of "private" and "public" headers in the gypi. You could no longer auto-gen this gypi list from the file system for example. But I think these are also things we can make better decisions on as we get further in this process.
Adam Barth
Comment 3 2011-03-01 16:51:51 PST
My understanding is that the prolific private headers are only required because of the ForwardingHeaders design. Once we change the Apple-internal submission script to submit the Source directory instead of the individual frameworks, then I suspect we'll be able to remove most (if not all) of the private headers.
WebKit Commit Bot
Comment 4 2011-03-01 22:11:26 PST
The commit-queue encountered the following flaky tests while processing attachment 84321 [details]: inspector/debugger/debugger-breakpoints-not-activated-on-reload.html bug 55551 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-03-01 22:14:33 PST
Comment on attachment 84321 [details] Patch Clearing flags on attachment: 84321 Committed r80094: <http://trac.webkit.org/changeset/80094>
WebKit Commit Bot
Comment 6 2011-03-01 22:14:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.