Bug 55507

Summary: Add pre- and post-build actions for JavaScriptCore GYP build
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, fataxef, pswag994
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch abarth: review-

Description Adam Barth 2011-03-01 14:19:06 PST
Add pre- and post-build actions for JavaScriptCore GYP build
Comment 1 Adam Barth 2011-03-01 14:31:40 PST
Created attachment 84295 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-01 14:49:40 PST
Comment on attachment 84295 [details]
Patch

Lovely.
Comment 3 Mark Rowe (bdash) 2011-03-01 15:02:07 PST
Comment on attachment 84295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84295&action=review

> Source/gyp/common.gypi:12
> +            'sh', '<(DEPTH)/gyp/update-info-plist.sh', '<(DEPTH)/JavaScriptGlue/Info.plist'

Why is a common file always working with JavaScriptGlue’s Info.plist?
Comment 4 Adam Barth 2011-03-01 15:20:20 PST
Comment on attachment 84295 [details]
Patch

Sounds like a bug.
Comment 5 Adam Barth 2011-03-01 16:48:16 PST
Committed r80065: <http://trac.webkit.org/changeset/80065>