Bug 55152

Summary: Add RenderMediaControls to Mac build, unduplicate one method.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, darin, eric.carlson, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 53020, 55157    
Attachments:
Description Flags
Patch eric.carlson: review+, dglazkov: commit-queue-

Dimitri Glazkov (Google)
Reported 2011-02-24 09:04:51 PST
Add RenderMediaControls to Mac build, unduplicate one method.
Attachments
Patch (11.39 KB, patch)
2011-02-24 09:07 PST, Dimitri Glazkov (Google) 		eric.carlson: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-02-24 09:07:17 PST
Created attachment 83666 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-02-24 10:54:27 PST
Committed r79591: <http://trac.webkit.org/changeset/79591>
WebKit Review Bot
Comment 3 2011-02-24 15:59:11 PST
http://trac.webkit.org/changeset/79591 might have broken GTK Linux 32-bit Release
Alexey Proskuryakov
Comment 4 2011-02-24 23:01:07 PST
+// FIXME: Is this necessary anymore? #define wkMediaControllerThemeAvailable(themeStyle) WKMediaControllerThemeAvailable(themeStyle) Unfortunately, yes - this is necessary because there is a mistake (incorrect capitalization) in WKSI on Windows, which we should fix on some lazy afternoon.
Note You need to log in before you can comment on or make changes to this bug.