Summary: | FETurbulenceElement changes doesn't require relayout. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||
Component: | SVG | Assignee: | Renata Hodovan <rhodovan.u-szeged> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 55075 | ||||||||
Attachments: |
|
Description
Renata Hodovan
2011-02-24 06:48:57 PST
Created attachment 83795 [details]
Proposed patch
Attachment 83795 [details] did not build on win: Build output: http://queues.webkit.org/results/8023003 Comment on attachment 83795 [details]
Proposed patch
r=me.
Comment on attachment 83795 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review > Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128 > + if (m_numOctaves == numOctaves) > + return false; m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.) (In reply to comment #4) > (From update of attachment 83795 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review > > > Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128 > > + if (m_numOctaves == numOctaves) > > + return false; > > m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.) Yeah, i see it already and supplement the patch immediately. Created attachment 83799 [details]
Proposed patch
Fix the parameter type of FETurbulence::setNumOctaves which caused the broken WIN bot.
Comment on attachment 83799 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=83799&action=review r=me, but please update the symbols in Source/WebCore/WebCore.order wrt TurbulanceType/TurbulenceType as well. > Source/WebCore/ChangeLog:13 > + No new tests are needed because this modificiation is covered by the dynamic update tests of FETurbulence. Typo, modification. Committed r79851: <http://trac.webkit.org/changeset/79851> |