Bug 54708

Summary: webkitpy.layout_tests.port.mock_drt_unittest fails on win32
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
aroben: review+
Patch none

Dirk Pranke
Reported 2011-02-17 18:58:44 PST
the unit test attempts to mock out the default port on the platform, but the default on 'win32', rightly or wrongly, is 'win', and not 'chromium-win'. And 'win' doesn't work - see bug 38756.
Attachments
Patch (1.62 KB, patch)
2011-02-17 19:01 PST, Dirk Pranke 		aroben: review+
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2011-02-17 19:05 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-17 19:01:25 PST
Created attachment 82894 [details] Patch
Dirk Pranke
Comment 2 2011-02-17 19:05:04 PST
Created attachment 82896 [details] Patch
Dirk Pranke
Comment 3 2011-02-17 19:07:16 PST
Comment on attachment 82896 [details] Patch darn ... wrong bug.
Adam Roben (:aroben)
Comment 4 2011-02-17 19:38:10 PST
Comment on attachment 82894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82894&action=review > Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:46 > + if sys.platform == 'win32': > + return mock_drt.MockDRTPort(port_name='mock-chromium-win') You could add a FIXME here referencing bug 48728 and a desire to test both chromium-win and win.
Dirk Pranke
Comment 5 2011-02-18 15:40:28 PST
Committed r79041: <http://trac.webkit.org/changeset/79041>
Note You need to log in before you can comment on or make changes to this bug.