Bug 54622

Summary:

Rename Position::node() to Position::deprecatedNode()

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

52099

Attachments:

Description	Flags
r? to see build errors on non-Mac ports	none
second attempt; r? to see build errors on non-Mac ports	none
3rd attempt; r? to see build errors on non-Mac ports	none
4th attempt	tkent: review+

Ryosuke Niwa

Reported 2011-02-17 00:56:46 PST

I changed my mind. I used to think that this will unnecessarily pollute svn blame. However, I realized that it's extremely hard to recognize all call sites of Position::node() in the presence of RenderObject::node()

Attachments
r? to see build errors on non-Mac ports (198.52 KB, patch) 2011-02-17 01:05 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
second attempt; r? to see build errors on non-Mac ports (200.84 KB, patch) 2011-02-17 02:55 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
3rd attempt; r? to see build errors on non-Mac ports (205.36 KB, patch) 2011-02-17 03:24 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
4th attempt (209.16 KB, patch) 2011-02-17 03:48 PST, Ryosuke Niwa	tkent: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2011-02-17 01:05:55 PST

Created attachment 82765 [details] r? to see build errors on non-Mac ports

WebKit Review Bot

Comment 2 2011-02-17 01:09:26 PST

Attachment 82765 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Last 3072 characters of output: he left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/editing/ReplaceSelectionCommand.cpp:796: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/editing/CompositeEditCommand.cpp:732: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/WebCore/editing/DeleteSelectionCommand.cpp:510: Declaration has space between type name and * in Text *text [whitespace/declaration] [3] Source/WebCore/editing/DeleteSelectionCommand.cpp:523: Declaration has space between type name and * in Node *n [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:390: Declaration has space between type name and * in RenderText *textRenderer [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:411: Declaration has space between type name and * in Node *fromRootEditableElement [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:439: Declaration has space between type name and * in Node *fromRootEditableElement [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:767: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:803: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:863: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:867: Declaration has space between type name and * in RenderObject *posRenderer [whitespace/declaration] [3] Source/WebCore/dom/Position.cpp:931: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/dom/Position.cpp:932: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/dom/Position.cpp:936: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/dom/Position.cpp:937: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/editing/ApplyStyleCommand.cpp:673: Declaration has space between type name and * in Node *startNode [whitespace/declaration] [3] Source/WebCore/editing/htmlediting.cpp:886: Declaration has space between type name and * in Node *node [whitespace/declaration] [3] Source/WebCore/editing/InsertTextCommand.cpp:171: Declaration has space between type name and * in Text *textNode [whitespace/declaration] [3] Source/WebCore/editing/InsertTextCommand.cpp:212: Declaration has space between type name and * in Node *node [whitespace/declaration] [3] Total errors found: 31 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2011-02-17 01:26:27 PST

Attachment 82765 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7926605

Collabora GTK+ EWS bot

Comment 4 2011-02-17 02:24:46 PST

Attachment 82765 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7917765

Ryosuke Niwa

Comment 5 2011-02-17 02:55:57 PST

Created attachment 82774 [details] second attempt; r? to see build errors on non-Mac ports

Collabora GTK+ EWS bot

Comment 6 2011-02-17 03:02:47 PST

Attachment 82774 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7920690