Bug 54076

Summary:

[GTK] Add new files to compilation after r77974

Product:

WebKit

Reporter:

Alejandro G. Castro <alex>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, mrobinson, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

52805

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	mrobinson: review+

Alejandro G. Castro

Reported 2011-02-09 00:54:15 PST

New code to allow passing context to policy delegate methods: bug 54031

Attachments
Proposed patch (4.10 KB, patch) 2011-02-09 00:57 PST, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Proposed patch (5.72 KB, patch) 2011-03-08 04:33 PST, Alejandro G. Castro	mrobinson: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alejandro G. Castro

Comment 1 2011-02-09 00:57:24 PST

Created attachment 81765 [details] Proposed patch

Alejandro G. Castro

Comment 2 2011-02-09 06:18:20 PST

Comment on attachment 81765 [details] Proposed patch Just found r77974 causes problems with the page loading, probably we will need to do more things in this patch to make it work.

Martin Robinson

Comment 3 2011-03-07 11:37:22 PST

What's the status on this issue?

Alejandro G. Castro

Comment 4 2011-03-07 12:14:14 PST

(In reply to comment #3) > What's the status on this issue? We still need to check the policy handling and fix the problem that causes the problem loading, not sure but could be an easy fix, just some method not implemented of no correctly doing what it should. You can check that applying the patch compilations works but the rendering does not happen and reverting the patch you get the rendering correctly.

Alejandro G. Castro

Comment 5 2011-03-08 03:07:15 PST

I had to check this issue now because after the last patches we can not easily avoid it. Apparently decidePolicyForNavigationAction message does not work, for some reason, sendSync returns false. I've checked that discarding the return value and passing PolicyUse directly to the frame everything works. Not sure how to to test the message issues, adding people to the CC that probably know how to do it.

Alejandro G. Castro

Comment 6 2011-03-08 04:07:35 PST

I think I found the issue, we have to implement the encode/decodeResourceRequest and resourceResponse.

Alejandro G. Castro

Comment 7 2011-03-08 04:33:49 PST

Created attachment 85042 [details] Proposed patch Added dummy encoders just so make it work and added a bug to implement the proper support: bug 55934

Alejandro G. Castro

Comment 8 2011-03-08 10:43:40 PST

Thanks for the review Matin, landed http://trac.webkit.org/changeset/80571

Note You need to log in before you can comment on or make changes to this bug.