Replace FLT_MAX with std::numeric_limits

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 81379 [details]
Patch

[WebKit Review Bot]

Attachment 81379 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7701469

[Patrick R. Gansterer]

Created attachment 81399 [details]
Patch

[Andreas Kling]

Comment on attachment 81399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81399&action=review

r=me

> Source/WebCore/html/NumberInputType.cpp:-54
> -static const double numberDefaultMinimum = -FLT_MAX;
> -static const double numberDefaultMaximum = FLT_MAX;

This looked a little strange to me, but apparently it is intentional:
https://bugs.webkit.org/show_bug.cgi?id=48221 (just for reference)

[WebKit Commit Bot]

Comment on attachment 81399 [details]
Patch

Rejecting attachment 81399 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'build-..." exit_code: 2

Last 500 characters of output:
HTMLImageElement ..........
fast/dom/HTMLInputElement ...........
fast/dom/HTMLKeygenElement .
fast/dom/HTMLLabelElement ...
fast/dom/HTMLLabelElement/form .
fast/dom/HTMLLinkElement ...
fast/dom/HTMLMetaElement .
fast/dom/HTMLMeterElement ............
fast/dom/HTMLMeterElement/set-meter-properties.html -> failed

Exiting early after 1 failures. 7347 tests run.
154.30s total testing time

7346 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
4 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7699743

[Patrick R. Gansterer]

Created attachment 81413 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 81413 [details]
Patch

Clearing flags on attachment: 81413

Committed r77774: <http://trac.webkit.org/changeset/77774>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.