Bug 53786 – check-webkit-style: The error message about NULL should be more clear for comments.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Levin]

There have been at least three bugs filed about this and probably other times people thought it was in error and didn't file a bug.
  https://bugs.webkit.org/show_bug.cgi?id=31215
  https://bugs.webkit.org/show_bug.cgi?id=34605
  https://bugs.webkit.org/show_bug.cgi?id=53755

This is my attempt to help clarify the issue.

[David Levin]

Created attachment 81243 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 81243 [details]
Patch

What's "null"?

[Eric Seidel (no email)]

I support the "comments" thing, I'm not sure I understand the "null" bit.

[David Levin]

(In reply to comment #3)
> I support the "comments" thing, I'm not sure I understand the "null" bit.

I don't know if I get it either, but I going with what I've seen other say. For example, https://bugs.webkit.org/show_bug.cgi?id=34605#c2

And it appears in https://bugs.webkit.org/show_bug.cgi?id=53749 the patch author took the "null" route.

[Eric Seidel (no email)]

I see.  Using "null" in comments.  But "null" isn't a language primitive, or is it?  I can never remember.

[David Levin]

(In reply to comment #5)
> I see.  Using "null" in comments.  But "null" isn't a language primitive, or is it?  I can never remember.
No.

This particular line should only be printed for comments actually. The style checker has special logic to catch NULL in comments and people think it is a bug so I changed the text on this instance of the message to make it more clear.

[Eric Seidel (no email)]

Comment on attachment 81243 [details]
Patch

Oh.  OK.  it wasn't clear to me that tis' a comment-only message.

[WebKit Commit Bot]

Comment on attachment 81243 [details]
Patch

Clearing flags on attachment: 81243

Committed r78100: <http://trac.webkit.org/changeset/78100>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.