Bug 53184

Summary:

Allow inter-ideograph justification for CJK

Product:

WebKit

Reporter:

mitz

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dglazkov, Hironori.Fujii, webkit-ews, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=205321

Attachments:

Description	Flags
Cross-platform and Mac parts	none
Cross-platform and Mac parts	none
Cross-platform and Mac parts	none
Cross-platform and Mac parts	hyatt: review+
Cross-platform and Mac parts	none
Patch with build fixes and vertical-rl test	none

mitz

Reported 2011-01-26 11:58:38 PST

<rdar://problem/8446709>

Attachments
Cross-platform and Mac parts (503.44 KB, patch) 2011-01-26 12:04 PST, mitz	no flags	Details Formatted Diff Diff
Cross-platform and Mac parts (512.49 KB, patch) 2011-01-26 13:11 PST, mitz	no flags	Details Formatted Diff Diff
Cross-platform and Mac parts (512.97 KB, patch) 2011-01-26 13:41 PST, mitz	no flags	Details Formatted Diff Diff
Cross-platform and Mac parts (512.98 KB, patch) 2011-01-26 14:05 PST, mitz	hyatt: review+	Details Formatted Diff Diff
Cross-platform and Mac parts (deleted) 2011-01-26 16:06 PST, mitz	no flags	Details
Patch with build fixes and vertical-rl test (771.65 KB, patch) 2011-01-26 16:50 PST, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2011-01-26 12:04:20 PST

Created attachment 80217 [details] Cross-platform and Mac parts

WebKit Review Bot

Comment 2 2011-01-26 12:30:53 PST

Attachment 80217 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7556341

Build Bot

Comment 3 2011-01-26 12:41:15 PST

Attachment 80217 [details] did not build on win: Build output: http://queues.webkit.org/results/7535314

mitz

Comment 4 2011-01-26 13:11:39 PST

Created attachment 80226 [details] Cross-platform and Mac parts

Early Warning System Bot

Comment 5 2011-01-26 13:15:40 PST

Attachment 80217 [details] did not build on qt: Build output: http://queues.webkit.org/results/7586309

WebKit Review Bot

Comment 6 2011-01-26 13:31:21 PST

Attachment 80226 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7591358

mitz

Comment 7 2011-01-26 13:41:32 PST

Created attachment 80227 [details] Cross-platform and Mac parts

Build Bot

Comment 8 2011-01-26 13:47:33 PST

Attachment 80226 [details] did not build on win: Build output: http://queues.webkit.org/results/7581343

WebKit Review Bot

Comment 9 2011-01-26 13:55:28 PST

Attachment 80227 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7534383

mitz

Comment 10 2011-01-26 14:05:39 PST

Created attachment 80233 [details] Cross-platform and Mac parts

Build Bot

Comment 11 2011-01-26 14:23:05 PST

Attachment 80227 [details] did not build on win: Build output: http://queues.webkit.org/results/7493363

WebKit Review Bot

Comment 12 2011-01-26 14:24:49 PST

Attachment 80217 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7596334

Dave Hyatt

Comment 13 2011-01-26 14:50:38 PST

Comment on attachment 80233 [details] Cross-platform and Mac parts I know it runs the same code path, but a vertical-rl test would be nice here as well, and it would be easy to add. r=me

WebKit Review Bot

Comment 14 2011-01-26 15:07:56 PST

Attachment 80233 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7627335

Build Bot

Comment 15 2011-01-26 15:09:38 PST

Attachment 80233 [details] did not build on win: Build output: http://queues.webkit.org/results/7593330

mitz

Comment 16 2011-01-26 16:06:26 PST

Created attachment 80255 [details] Cross-platform and Mac parts Build fix edition

mitz

Comment 17 2011-01-26 16:10:56 PST

Comment on attachment 80255 [details] Cross-platform and Mac parts Marking r? to get this building on the bots.

William Siegrist

Comment 18 2011-01-26 16:38:57 PST

The content of attachment 80255 [details] has been deleted by William Siegrist <wsiegrist@apple.com> who provided the following reason: Deleted by request of mitzpettel The token used to delete this attachment was generated at 2011-01-26 16:38:33 PST.

mitz

Comment 19 2011-01-26 16:50:18 PST

Created attachment 80266 [details] Patch with build fixes and vertical-rl test

mitz

Comment 20 2011-01-26 17:40:41 PST

Committed r76743. <http://trac.webkit.org/changeset/76743>

Note You need to log in before you can comment on or make changes to this bug.