Bug 53041

Summary:

Change ENABLE_3D_CANVAS to ENABLE_WEBGL

Product:

WebKit

Reporter:

Chris Marrin <cmarrin>

Component:

WebGL

Assignee:

Chris Marrin <cmarrin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, gustavo, kbr, mrobinson, rectalogic, webkit.review.bot, xan.lopez, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

53714

Attachments:

Description	Flags
Patch	none
Patch	eric: review+
Fix build-webkit to use ENABLE_WEBGL	kbr: review-
Fix build-webkit to use ENABLE_WEBGL	kbr: review-

Chris Marrin

Reported 2011-01-24 13:39:11 PST

This will make the source less confusing

Attachments
Patch (99.49 KB, patch) 2011-01-24 15:14 PST, Chris Marrin	no flags	Details Formatted Diff Diff
Patch (101.59 KB, patch) 2011-01-24 16:03 PST, Chris Marrin	eric: review+	Details Formatted Diff Diff
Fix build-webkit to use ENABLE_WEBGL (842 bytes, patch) 2011-01-29 14:11 PST, Andrew Wason	kbr: review-	Details Formatted Diff Diff
Fix build-webkit to use ENABLE_WEBGL (1.40 KB, patch) 2011-01-31 07:39 PST, Andrew Wason	kbr: review-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Marrin

Comment 1 2011-01-24 15:14:53 PST

Created attachment 79981 [details] Patch

Eric Seidel (no email)

Comment 2 2011-01-24 15:19:48 PST

Sounds sane to me.

Eric Seidel (no email)

Comment 3 2011-01-24 15:20:10 PST

Comment on attachment 79981 [details] Patch rs=me. You should definitely wait for the EWS bots to pass.

WebKit Review Bot

Comment 4 2011-01-24 15:27:40 PST

Attachment 79981 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7608329

Martin Robinson

Comment 5 2011-01-24 15:35:27 PST

For GTK+, you also need to change the AM_CONDITIONAL line in configure.ac in the root directory of the repository.

Kenneth Russell

Comment 6 2011-01-24 15:39:03 PST

FYI, http://codereview.chromium.org/6256013 is being landed in Chromium to prevent an interruption in WebGL support when this change lands.

Chris Marrin

Comment 7 2011-01-24 16:03:04 PST

Created attachment 79985 [details] Patch

Eric Seidel (no email)

Comment 8 2011-01-24 16:04:21 PST

Comment on attachment 79985 [details] Patch rs=me. (Again please let the ews chew this through.)

Chris Marrin

Comment 9 2011-01-24 16:12:03 PST

(In reply to comment #8) > (From update of attachment 79985 [details]) > rs=me. (Again please let the ews chew this through.) Will do. Hopefully I've fixed the GTK problem. I think the other two that didn't run on the first one will pass. But we'll see

Chris Marrin

Comment 10 2011-01-25 09:27:53 PST

Committed r76600: <http://trac.webkit.org/changeset/76600>

Zhenyao Mo

Comment 11 2011-01-25 09:35:05 PST

Committed r76601: <http://trac.webkit.org/changeset/76601>

Zhenyao Mo

Comment 12 2011-01-25 09:39:50 PST

Seems like update-webkit failed to correctly merge the change log, and my patch ended up in the wrong bug. Should be placed in bug 52338

WebKit Review Bot

Comment 13 2011-01-25 10:49:32 PST

http://trac.webkit.org/changeset/76600 might have broken GTK Linux 64-bit Debug

WebKit Review Bot

Comment 14 2011-01-25 10:49:39 PST

http://trac.webkit.org/changeset/76601 might have broken GTK Linux 64-bit Debug

Andrew Wason

Comment 15 2011-01-29 14:11:11 PST

Created attachment 80571 [details] Fix build-webkit to use ENABLE_WEBGL Tools/Scripts/build-webkit needs to change ENABLE_3D_CANVAS to ENABLE_WEBGL.

Kenneth Russell

Comment 16 2011-01-30 20:36:06 PST

Comment on attachment 80571 [details] Fix build-webkit to use ENABLE_WEBGL Could you please regenerate this patch using the prepare-ChangeLog and svn-create-patch scripts described in http://webkit.org/coding/contributing.html ? It might also be helpful to file a new bug report and point it at this one, just so the dependency chain can be tracked.

Andrew Wason

Comment 17 2011-01-31 07:39:04 PST

Created attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL regenerate patch using prepare-ChangeLog and svn-create-patch scripts

Kenneth Russell

Comment 18 2011-01-31 23:11:19 PST

Comment on attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL Looks okay to me. Let's let the commit queue process it.

Andrew Wason

Comment 19 2011-02-03 13:44:22 PST

(In reply to comment #18) > Looks okay to me. Let's let the commit queue process it. I still don't see this patch in the queue - maybe it won't queue it because this bug is closed?

Kenneth Russell

Comment 20 2011-02-03 13:48:25 PST

(In reply to comment #19) > (In reply to comment #18) > > Looks okay to me. Let's let the commit queue process it. > > I still don't see this patch in the queue - maybe it won't queue it because this bug is closed? It's possible. Would you please file a new bug and regenerate the patch against it? It will make tracking this change easier.

Andrew Wason

Comment 21 2011-02-03 14:09:46 PST

(In reply to comment #20) > It's possible. Would you please file a new bug and regenerate the patch against it? It will make tracking this change easier. Created bug 53714

Eric Seidel (no email)

Comment 22 2011-02-03 16:41:52 PST

The queue does not process patches on closed bugs. You could re-open the bug and the queue would see it though.

Kenneth Russell

Comment 23 2011-02-03 16:44:07 PST

(In reply to comment #22) > The queue does not process patches on closed bugs. You could re-open the bug and the queue would see it though. Thanks, I didn't know that. I think it would be best to apply the patch under the new bug and will review it shortly.

Kenneth Russell

Comment 24 2011-02-03 16:44:37 PST

Comment on attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL Will review the patch on the new bug.

Note You need to log in before you can comment on or make changes to this bug.