Bug 52748

Summary: nrwt: convert port/* modules to using the filesystem wrappers
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52753    
Attachments:
Description Flags
Patch
none
Patch
none
fix MockFileSystem.read_text_file() to raise KeyError if we don't know the file, fix isdir() to be thread-safe
none
keep a copy of the file list; using a list comprehension didn't work none

Dirk Pranke
Reported 2011-01-19 14:40:18 PST
nrwt: convert port/* modules to using the filesystem wrappers
Attachments
Patch (22.36 KB, patch)
2011-01-19 14:40 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (22.42 KB, patch)
2011-01-19 14:42 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix MockFileSystem.read_text_file() to raise KeyError if we don't know the file, fix isdir() to be thread-safe (23.03 KB, patch)
2011-01-19 14:51 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
keep a copy of the file list; using a list comprehension didn't work (23.03 KB, patch)
2011-01-19 15:14 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-01-19 14:40:36 PST
Created attachment 79488 [details] Patch
Dirk Pranke
Comment 2 2011-01-19 14:42:02 PST
Created attachment 79489 [details] Patch
Dirk Pranke
Comment 3 2011-01-19 14:51:59 PST
Created attachment 79492 [details] fix MockFileSystem.read_text_file() to raise KeyError if we don't know the file, fix isdir() to be thread-safe
Dirk Pranke
Comment 4 2011-01-19 15:14:25 PST
Created attachment 79499 [details] keep a copy of the file list; using a list comprehension didn't work
Dirk Pranke
Comment 5 2011-01-19 17:49:27 PST
Comment on attachment 79499 [details] keep a copy of the file list; using a list comprehension didn't work Clearing flags on attachment: 79499 Committed r76184: <http://trac.webkit.org/changeset/76184>
Dirk Pranke
Comment 6 2011-01-19 17:49:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.