Summary: | Volume slider for audio element does not fully display in Qt | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rosenblatt <keith.rosenblatt> | ||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | keith.rosenblatt, laszlo.gombos, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Keith Rosenblatt
2011-01-14 13:17:46 PST
Created attachment 79301 [details]
Fix to Qt media control CSS
Created attachment 79446 [details]
Fix to Qt media control CSS
Drop unnecessary pixel test
Comment on attachment 79446 [details]
Fix to Qt media control CSS
The test lacks expected results for platforms other than Qt.
Comment on attachment 79446 [details]
Fix to Qt media control CSS
r- to fix expected results for other ports. An entry in the Skipped lists with a comment will do it.
(In reply to comment #4) > (From update of attachment 79446 [details]) > r- to fix expected results for other ports. An entry in the Skipped lists with a comment will do it. I am afraid skipping the test for other can not be ideal, since this is changing default .css files. - overflow: hidden; + overflow: visible; height: 100%; I would suggest at least also checking in Mac expected files... I am afraid skipping the test for other can not be ideal, since this is changing default .css files.
> I would suggest at least also checking in Mac expected files...
Correcting myself, the file being changed is Qt-only, so no worries.
Another option is adding the test to LayoutTest/platform/qt/xxx/yyy , so it will only run on QtWebKit, and does not need to be skipped to others.
Up to you ...
Comment on attachment 79446 [details] Fix to Qt media control CSS Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=52822 |