Summary: | fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots (due to ATSServer leak) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, aestes, aroben, eric, hyatt, jberlin, mihaip, mrowe, webkit.review.bot, wsiegrist | ||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, MakingBotsRed, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Barth
2011-01-02 21:39:01 PST
Failure seen as early as http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25125 Sat Dec 25 09:57:48 2010 Skipped in http://trac.webkit.org/changeset/74888 As far as I can tell, this test started failing during some kind of buildbot maintenance. Prior to build 25125, there don't seem to be any failures, but 25125 seems to be the first build with a new buildbot configuration. The same revision was tested in a prior build, which did not show the error (although it did how other failing tests which magically disappeared). Thoughts? Now that I've skipped this test, fast/blockflow/broken-ideographic-font.html has started failing instead, which is the next test alphabetically. That would seem to implicate box-shadow-vertical-rl.html, which is the previous test alphabetically. I unskipped the test in http://trac.webkit.org/changeset/75683. The problem seems likely to be caused by an earlier test. This test started failing again on the Leopard bots today around r81371/r81372. None of the revisions around then seem related. The test seems to be failing in both Debug and Release and on all of the slaves, so it's not configuration-specific. Here's an example of the current failure: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81376%20(29906)/fast/blockflow/broken-ideographic-font-pretty-diff.html This seems to have stopped failing again. The test has resumed failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r84943%20(31499)/results.html I am not sure when this bout of failing began. *** Bug 59649 has been marked as a duplicate of this bug. *** (In reply to comment #10) > The test has resumed failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r84943%20(31499)/results.html > > I am not sure when this bout of failing began. As far back on the bot as I can see, which is currently http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31371 I'm going to skip fast/blockflow/broken-ideograph-font.html on Leopard. It doesn't seem related to box-shadow-vertical-rl.html since broken-ideograph-small-caps.html isn't skipped and doesn't fail. It's hard to say if this is a failure or a rebaseline situation without seeing pixel results. Skipped in http://trac.webkit.org/changeset/85130 *** Bug 59780 has been marked as a duplicate of this bug. *** It looks like these test failures are being caused by an ATSServer leak. ATSServer slowly uses more and more memory and eventually these tests start failing. Cycling ATSServer using launchctl stop/start seems to fix things. Dan Bernstein suggests that we cycle ATSServer at the start or end of each test run to avoid this issue. Unskipped the tests in r85306. Created attachment 91645 [details]
Stop and restart ATSServer before each test run on Leopard
Committed r85307: <http://trac.webkit.org/changeset/85307> http://trac.webkit.org/changeset/85306 might have broken SnowLeopard Intel Release (Build) http://trac.webkit.org/changeset/85307 might have broken SnowLeopard Intel Release (Build) |