Bug 51807

Summary: fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots (due to ATSServer leak)
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aestes, aroben, eric, hyatt, jberlin, mihaip, mrowe, webkit.review.bot, wsiegrist
Priority: P2 Keywords: InRadar, LayoutTestFailure, MakingBotsRed, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Stop and restart ATSServer before each test run on Leopard mitz: review+

Description Adam Barth 2011-01-02 21:39:01 PST
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r74885%20(25337)/results.html

This test has been failing for many days.
Comment 1 Adam Barth 2011-01-02 21:47:08 PST
Failure seen as early as http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25125

Sat Dec 25 09:57:48 2010
Comment 2 Adam Barth 2011-01-02 21:50:29 PST
Skipped in http://trac.webkit.org/changeset/74888
Comment 3 Adam Barth 2011-01-02 21:54:10 PST
As far as I can tell, this test started failing during some kind of buildbot maintenance.  Prior to build 25125, there don't seem to be any failures, but 25125 seems to be the first build with a new buildbot configuration.  The same revision was tested in a prior build, which did not show the error (although it did how other failing tests which magically disappeared).

Thoughts?
Comment 4 Adam Barth 2011-01-03 10:57:30 PST
Now that I've skipped this test, 
fast/blockflow/broken-ideographic-font.html has started failing instead, which is the next test alphabetically.  That would seem to implicate box-shadow-vertical-rl.html, which is the previous test alphabetically.
Comment 5 Adam Barth 2011-01-12 23:28:28 PST
I unskipped the test in http://trac.webkit.org/changeset/75683.  The problem seems likely to be caused by an earlier test.
Comment 6 Adam Roben (:aroben) 2011-03-17 13:09:28 PDT
This test started failing again on the Leopard bots today around r81371/r81372. None of the revisions around then seem related. The test seems to be failing in both Debug and Release and on all of the slaves, so it's not configuration-specific.
Comment 8 Adam Roben (:aroben) 2011-03-18 02:15:57 PDT
This seems to have stopped failing again.
Comment 9 Jessie Berlin 2011-04-12 13:57:40 PDT
<rdar://problem/9273894>
Comment 10 Jessie Berlin 2011-04-26 13:47:09 PDT
The test has resumed failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r84943%20(31499)/results.html

I am not sure when this bout of failing began.
Comment 11 Andy Estes 2011-04-27 16:53:19 PDT
*** Bug 59649 has been marked as a duplicate of this bug. ***
Comment 12 Andy Estes 2011-04-27 16:57:50 PDT
(In reply to comment #10)
> The test has resumed failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r84943%20(31499)/results.html
> 
> I am not sure when this bout of failing began.

As far back on the bot as I can see, which is currently http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31371
Comment 13 Andy Estes 2011-04-27 17:21:27 PDT
I'm going to skip fast/blockflow/broken-ideograph-font.html on Leopard. It doesn't seem related to box-shadow-vertical-rl.html since broken-ideograph-small-caps.html isn't skipped and doesn't fail. It's hard to say if this is a failure or a rebaseline situation without seeing pixel results.
Comment 14 Andy Estes 2011-04-27 17:59:40 PDT
Skipped in http://trac.webkit.org/changeset/85130
Comment 15 Adam Roben (:aroben) 2011-04-28 23:25:31 PDT
*** Bug 59780 has been marked as a duplicate of this bug. ***
Comment 16 Adam Roben (:aroben) 2011-04-28 23:40:10 PDT
It looks like these test failures are being caused by an ATSServer leak. ATSServer slowly uses more and more memory and eventually these tests start failing. Cycling ATSServer using launchctl stop/start seems to fix things.

Dan Bernstein suggests that we cycle ATSServer at the start or end of each test run to avoid this issue.
Comment 17 Adam Roben (:aroben) 2011-04-28 23:42:18 PDT
Unskipped the tests in r85306.
Comment 18 Adam Roben (:aroben) 2011-04-28 23:50:58 PDT
Created attachment 91645 [details]
Stop and restart ATSServer before each test run on Leopard
Comment 19 Adam Roben (:aroben) 2011-04-28 23:56:34 PDT
Committed r85307: <http://trac.webkit.org/changeset/85307>
Comment 20 WebKit Review Bot 2011-04-28 23:59:02 PDT
http://trac.webkit.org/changeset/85306 might have broken SnowLeopard Intel Release (Build)
Comment 21 WebKit Review Bot 2011-04-28 23:59:07 PDT
http://trac.webkit.org/changeset/85307 might have broken SnowLeopard Intel Release (Build)