Bug 51700

Summary: [Qt] On Linux build of TestNetscapePlugin fails if gold linker is used
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, evan, jhanssen, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Link libX11 explicitly on unix none

Konstantin Tokarev
Reported 2010-12-29 01:45:28 PST
TestNetscapePlugin explicitly uses X11 functions but is not linked with libX11, and gold does not perform transitive linking Attached patch fixes the problem
Attachments
Link libX11 explicitly on unix (1.59 KB, patch)
2010-12-29 01:48 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2010-12-29 01:48:52 PST
Created attachment 77607 [details] Link libX11 explicitly on unix
Eric Seidel (no email)
Comment 2 2010-12-29 18:30:56 PST
Comment on attachment 77607 [details] Link libX11 explicitly on unix OK.
WebKit Commit Bot
Comment 3 2010-12-29 19:16:03 PST
The commit-queue encountered the following flaky tests while processing attachment 77607 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 51732 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-29 19:17:11 PST
Comment on attachment 77607 [details] Link libX11 explicitly on unix Clearing flags on attachment: 77607 Committed r74776: <http://trac.webkit.org/changeset/74776>
WebKit Commit Bot
Comment 5 2010-12-29 19:17:18 PST
All reviewed patches have been landed. Closing bug.
Jan Erik Hanssen
Comment 6 2011-01-05 13:25:18 PST
(In reply to comment #1) > Created an attachment (id=77607) [details] > Link libX11 explicitly on unix This broke linking of the Qt port on OS X, see bug 51948.
Note You need to log in before you can comment on or make changes to this bug.