Bug 51535

Summary: [GTK] Show current time / total in media player
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to show current time/total in media player none

Carlos Garcia Campos
Reported 2010-12-23 06:06:03 PST
Current media player doesn't show information about the current and total time.
Attachments
Patch to show current time/total in media player (3.43 KB, patch)
2010-12-23 06:08 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-12-23 06:08:00 PST
Created attachment 77330 [details] Patch to show current time/total in media player
Xan Lopez
Comment 2 2010-12-24 09:27:00 PST
Comment on attachment 77330 [details] Patch to show current time/total in media player View in context: https://bugs.webkit.org/attachment.cgi?id=77330&action=review > WebCore/css/mediaControlsGtk.css:63 > + As a bikeshed comment I'd say hardcoding stuff in pixels in our css files is less than ideal, but I see we are already doing it everywhere.
WebKit Commit Bot
Comment 3 2010-12-24 10:58:24 PST
The commit-queue encountered the following flaky tests while processing attachment 77330 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-24 11:02:42 PST
Comment on attachment 77330 [details] Patch to show current time/total in media player Clearing flags on attachment: 77330 Committed r74643: <http://trac.webkit.org/changeset/74643>
WebKit Commit Bot
Comment 5 2010-12-24 11:02:46 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2010-12-24 11:11:33 PST
The commit-queue encountered the following flaky tests while processing attachment 77330 [details]: http/tests/xmlhttprequest/open-async-overload.html bug 51594 (author: morrita@google.com) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 7 2010-12-24 12:40:16 PST
http://trac.webkit.org/changeset/74643 might have broken GTK Linux 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.