Bug 51408

Summary: matrix3d() must take the zoom factor into account
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: CSSAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, jhanssen, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Ariya Hidayat
Reported 2010-12-21 11:12:59 PST
Similar like https://bugs.webkit.org/show_bug.cgi?id=49774.
Attachments
Patch (8.26 KB, patch)
2010-12-21 16:51 PST, Jan Erik Hanssen 		no flags
DetailsFormatted DiffDiff
Patch (8.36 KB, patch)
2010-12-21 17:51 PST, Jan Erik Hanssen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Erik Hanssen
Comment 1 2010-12-21 16:51:59 PST
Created attachment 77166 [details] Patch
WebKit Review Bot
Comment 2 2010-12-21 16:56:41 PST
Attachment 77166 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.png', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.txt', u'LayoutTests/fast/transforms/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1 WebCore/css/CSSStyleSelector.cpp:6844: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/css/CSSStyleSelector.cpp:6845: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jan Erik Hanssen
Comment 3 2010-12-21 16:59:52 PST
(In reply to comment #2) > Attachment 77166 [details] did not pass style-queue: This seems to be bogus, static_cast is obviously not an identifier name.
Simon Fraser (smfr)
Comment 4 2010-12-21 17:29:12 PST
Comment on attachment 77166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77166&action=review > WebCore/ChangeLog:8 > + Test: fast/transforms/matrix-with-zoom-3d.html The test should go into transforms/3d.
Jan Erik Hanssen
Comment 5 2010-12-21 17:51:44 PST
Created attachment 77172 [details] Patch Change the test directory
WebKit Review Bot
Comment 6 2010-12-21 17:54:49 PST
Attachment 77172 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.png', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.txt', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1 WebCore/css/CSSStyleSelector.cpp:6844: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/css/CSSStyleSelector.cpp:6845: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ariya Hidayat
Comment 7 2010-12-21 19:42:53 PST
Comment on attachment 77172 [details] Patch Clearing flags on attachment: 77172 Committed r74451: <http://trac.webkit.org/changeset/74451>
Ariya Hidayat
Comment 8 2010-12-21 19:43:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.