Bug 51316

Summary: [Qt] Make sure touch and orientation events are disabled in the minimal configuration
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Laszlo Gombos <laszlo.gombos>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ossy, yael
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
previous patch + bearer mgmt none

Laszlo Gombos
Reported 2010-12-19 19:44:30 PST
Touch and orientation (not device orientation) features are not configurable from build-webkit script so they are not disabled in the minimal config. This means that builds with these features turned off are not tested by any bot.
Attachments
proposed patch (1.27 KB, patch)
2010-12-19 19:50 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
previous patch + bearer mgmt (1.34 KB, patch)
2010-12-19 20:21 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-12-19 19:50:11 PST
Created attachment 76971 [details] proposed patch
Laszlo Gombos
Comment 2 2010-12-19 20:21:46 PST
Created attachment 76972 [details] previous patch + bearer mgmt
Yael
Comment 3 2010-12-20 06:21:51 PST
I don't think this is the right way to add ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to Qt's minimal config. Instead of adding the flags to Qt's minimal config, they should be added to build-webkit script. From there, they are automatically added to the minimal config. Please see https://bugs.webkit.org/show_bug.cgi?id=48224 and https://bugs.webkit.org/show_bug.cgi?id=48185. Qt specific flags like ENABLE_QT_BEARER should be added this way.
Csaba Osztrogonác
Comment 4 2010-12-20 06:38:47 PST
I agree with Yael, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS should be disabled on all minimal build. They aren't Qt specific features.
Laszlo Gombos
Comment 5 2010-12-20 12:29:15 PST
Comment on attachment 76972 [details] previous patch + bearer mgmt Setting to cq- until bug 51346 is evaluated. Part of this patch will be needed to make sure that ENABLE_TOUCH_EVENTS can be turned off for QtWebKit.
Eric Seidel (no email)
Comment 6 2010-12-21 00:55:59 PST
Attachment 76972 [details] was posted by a committer and has review+, assigning to Laszlo Gombos for commit.
Laszlo Gombos
Comment 7 2011-01-07 14:14:13 PST
Comment on attachment 76972 [details] previous patch + bearer mgmt Relevant part of the patch committed as http://trac.webkit.org/changeset/75206. Clearing flags.
Laszlo Gombos
Comment 8 2011-02-16 16:58:54 PST
Closing bug.
Note You need to log in before you can comment on or make changes to this bug.