Bug 50989

Summary: Change SelectionController::setFocusedNodeIfNeeded code to use DOM traversal instead of render tree traversal
Product: WebKit Reporter: Emil A Eklund <eae>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Emil A Eklund 2010-12-13 15:28:03 PST
Per comment introduced in bug 49977 by dglazkov@chromium.org, we should use DOM traversal in discovering first focusable node, rather than render tree.
Comment 1 Emil A Eklund 2010-12-13 15:30:09 PST
A FIXME comment in setFocusedNodeIfNeeded suggest combining the traversal code with that in EventHandle::dispatchMouseEvent. I don't see how that would simplify things though as they both need to perform different additional checks on the node.
Comment 2 Emil A Eklund 2010-12-13 15:32:15 PST
Created attachment 76456 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2010-12-13 15:36:34 PST
Comment on attachment 76456 [details]
Patch

ok.
Comment 4 WebKit Review Bot 2010-12-13 16:25:04 PST
Comment on attachment 76456 [details]
Patch

Clearing flags on attachment: 76456

Committed r73984: <http://trac.webkit.org/changeset/73984>
Comment 5 WebKit Review Bot 2010-12-13 16:25:09 PST
All reviewed patches have been landed.  Closing bug.