Bug 50920

Summary:

Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation

Product:

WebKit

Reporter:

John Knottenbelt <jknotten>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, steveblock, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

50562

Attachments:

Description	Flags
Patch	none

Description John Knottenbelt 2010-12-13 06:17:53 PST

Use a valid error code (position unavailable == 2) to avoid an assertion failure in Chromium's client-based mock geolocation client.

Comment 1 John Knottenbelt 2010-12-13 06:19:23 PST

Created attachment 76379 [details]
Patch

Comment 2 Steve Block 2010-12-13 06:30:56 PST

Comment on attachment 76379 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2010-12-13 07:18:00 PST

The commit-queue encountered the following flaky tests while processing attachment 76379 [details]:

fast/profiler/throw-exception-from-eval.html bug 50923 (authors: kmccullough@apple.com, oliver@apple.com, and timothy@apple.com)
inspector/syntax-highlight-css.html bug 50924 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org)
The commit-queue is continuing to process your patch.

Comment 4 WebKit Commit Bot 2010-12-13 07:54:46 PST

Comment on attachment 76379 [details]
Patch

Clearing flags on attachment: 76379

Committed r73919: <http://trac.webkit.org/changeset/73919>

Comment 5 WebKit Commit Bot 2010-12-13 07:54:51 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 WebKit Review Bot 2010-12-13 09:05:55 PST

http://trac.webkit.org/changeset/73919 might have broken GTK Linux 64-bit Debug