Bug 50906

Summary: Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 50919    
Bug Blocks: 47775    
Description Flags
[patch] initialversion.
[patch] second iteration none

Description Ilya Tikhonovsky 2010-12-13 02:16:11 PST
Debugger and Resources related notification functions of Inspector.idl were marked as such with help of "domain" attribute.
The other changes in js files are reflecting this change. 
Some wrappers in WebInspector namespace were dropped, the others were moved to DebuggerModel class.
Comment 1 Ilya Tikhonovsky 2010-12-13 02:21:41 PST
Created attachment 76361 [details]
[patch] initialversion.

domain attribute was assigned to Resources, Profiler and Debugger notification functions.
Comment 2 Yury Semikhatsky 2010-12-13 02:45:04 PST
Comment on attachment 76361 [details]
[patch] initialversion.

View in context: https://bugs.webkit.org/attachment.cgi?id=76361&action=review

> WebCore/inspector/Inspector.idl:36
> +        [notify, fomain=Inspector] void addNodesToSearchResult(out Array nodeIds);

fomain -> domain

> WebCore/inspector/front-end/ProfilesPanel.js:433
> +    addHeapSnapshots: function(uid, chunk)

I don't see other places where this method name has changed, did you miss them?

> WebCore/inspector/front-end/ProfilesPanel.js:624
> +                    title: WebInspector.UIString("Recordingâ¦"),

The string looks corrupted.
Comment 3 Ilya Tikhonovsky 2010-12-13 03:06:26 PST
Created attachment 76365 [details]
[patch] second iteration

comments addressed
Comment 4 Yury Semikhatsky 2010-12-13 03:12:32 PST
Comment on attachment 76365 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=76365&action=review

> WebCore/inspector/front-end/DebuggerModel.js:185
> +

too many blank lines
Comment 5 Ilya Tikhonovsky 2010-12-13 03:21:46 PST
Committed r73898
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/Tests.js
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorProfilerAgent.cpp
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/front-end/DebuggerModel.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/ProfilesPanel.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/InspectorDebuggerAgent.cpp
	M	LayoutTests/http/tests/inspector/debugger-test2.js
	M	LayoutTests/ChangeLog
r73898 = 21577ea9200a18a3f7c7e70c2e57662f3c1c2f94 (refs/remotes/trunk)
Comment 6 WebKit Review Bot 2010-12-13 09:05:37 PST
http://trac.webkit.org/changeset/73916 might have broken GTK Linux 64-bit Debug