Bug 50808

Summary: [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 50783    
Bug Blocks:    
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch2
mrobinson: review+, commit-queue: commit-queue-
Proposed Patch3 none

Joone Hur
Reported 2010-12-10 04:44:21 PST
Unskipping: #userscripts/mixed-case-stylesheet.html #userscripts/simple-stylesheet.html #userscripts/user-style-all-frames.html
Attachments
Proposed Patch (6.50 KB, patch)
2010-12-10 05:08 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Proposed Patch2 (6.49 KB, patch)
2010-12-10 07:32 PST, Joone Hur 		mrobinson: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch3 (6.49 KB, patch)
2010-12-10 08:36 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2010-12-10 05:08:22 PST
Created attachment 76184 [details] Proposed Patch
Martin Robinson
Comment 2 2010-12-10 06:33:13 PST
Comment on attachment 76184 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76184&action=review > WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:56 > + static void addUserStyleSheet(WebKitWebFrame* mainFrame, const char* sourceCode, bool allFrames); Please remove the mainFrame variable name here.
Joone Hur
Comment 3 2010-12-10 07:32:24 PST
Created attachment 76197 [details] Proposed Patch2 Yes, I did it.
WebKit Commit Bot
Comment 4 2010-12-10 07:44:11 PST
Comment on attachment 76197 [details] Proposed Patch2 Rejecting attachment 76197 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf', 'apply-attachment', '--non-interactive', 76197]" exit_code: 2 Last 500 characters of output: pRenderTreeSupportGtk.cpp patching file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h.rej patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6896027
Joone Hur
Comment 5 2010-12-10 08:36:24 PST
Created attachment 76206 [details] Proposed Patch3 I fixed the confict with http://trac.webkit.org/changeset/73727
WebKit Commit Bot
Comment 6 2010-12-10 09:16:27 PST
Comment on attachment 76206 [details] Proposed Patch3 Clearing flags on attachment: 76206 Committed r73735: <http://trac.webkit.org/changeset/73735>
WebKit Commit Bot
Comment 7 2010-12-10 09:16:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.