| Summary: | [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joone Hur <joone> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, gustavo, mrobinson, webkit.review.bot, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 50808 | ||||||
| Attachments: |
|
||||||
Created attachment 76177 [details]
Proposed Patch1
Attachment 76177 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/Skipped', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:58: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 76177 [details]
Proposed Patch1
LGTM.
Comment on attachment 76177 [details] Proposed Patch1 Clearing flags on attachment: 76177 Committed r73714: <http://trac.webkit.org/changeset/73714> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug (In reply to comment #6) > http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug I tested it, but no build break. |
We need to implement pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet in LayoutTestControllerGtk.cpp for unskipping: printing/page-rule-selection.html printing/page-format-data.html