Bug 50783

Summary: [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 50808    
Attachments:
Description Flags
Proposed Patch1 none

Joone Hur
Reported 2010-12-09 13:32:36 PST
We need to implement pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet in LayoutTestControllerGtk.cpp for unskipping: printing/page-rule-selection.html printing/page-format-data.html
Attachments
Proposed Patch1 (9.87 KB, patch)
2010-12-10 02:10 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2010-12-10 02:10:22 PST
Created attachment 76177 [details] Proposed Patch1
WebKit Review Bot
Comment 2 2010-12-10 02:12:32 PST
Attachment 76177 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/Skipped', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1 WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:58: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2010-12-10 02:37:35 PST
Comment on attachment 76177 [details] Proposed Patch1 LGTM.
WebKit Commit Bot
Comment 4 2010-12-10 03:04:45 PST
Comment on attachment 76177 [details] Proposed Patch1 Clearing flags on attachment: 76177 Committed r73714: <http://trac.webkit.org/changeset/73714>
WebKit Commit Bot
Comment 5 2010-12-10 03:04:50 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-12-10 11:46:35 PST
http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug
Joone Hur
Comment 7 2010-12-11 04:31:48 PST
(In reply to comment #6) > http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug I tested it, but no build break.
Note You need to log in before you can comment on or make changes to this bug.