Bug 50706

Summary:

[GTK] media/video-controls-transformed.html fails

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

atwilson, eric.carlson, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	eric.carlson: review-

Description Philippe Normand 2010-12-08 12:02:15 PST

A CSS rotation is applied to a video element and the event sender clicks at a fixed position supposed to be the play button. But this depends on the controls. So we should instead calculate the position depending on the video dimensions and rotation angle.

Comment 1 Philippe Normand 2010-12-08 12:05:35 PST

Created attachment 75942 [details]
proposed patch

Comment 2 Philippe Normand 2010-12-08 12:06:34 PST

Comment on attachment 75942 [details]
proposed patch

Would something like this make sense Eric? If so can you please check the test still passes on mac?

Comment 3 Eric Carlson 2010-12-24 12:06:15 PST

Comment on attachment 75942 [details]
proposed patch

This doesn't work on the Mac. The mouse is clicked at {2,182}, but the center of the play/pause button is at about {194,24}.

I think the only way to make this work for all ports will be for DRT to get the location of the control elements from the shadow tree at runtime.

Comment 4 Philippe Normand 2011-05-03 02:13:03 PDT

r85015 fixed this test like Eric suggested. I'll unskip it on GTK since it passes fine now!

*** This bug has been marked as a duplicate of bug 58590 ***

Comment 5 Philippe Normand 2011-05-03 02:31:47 PDT

Committed r85594: <http://trac.webkit.org/changeset/85594>