Summary: | [GTK] DRT needs layoutTestController.setCacheModel | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joone Hur <joone> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, mrobinson, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Bug Depends on: | 42684 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Joone Hur
2010-12-08 12:01:52 PST
Created attachment 75944 [details]
Proposed Patch
Attachment 75944 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:569: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 75944 [details]
Proposed Patch
Okay. It seems that the one test that uses this is already passing. It's good to have an implementation though.
The commit-queue encountered the following flaky tests while processing attachment 75944 [details]: animations/suspend-resume-animation.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and cmarrin@apple.com. The commit-queue is continuing to process your patch. Comment on attachment 75944 [details] Proposed Patch Rejecting patch 75944 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: ociatedElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameLoader.o /Projects/CommitQueue/WebCore/loader/FrameLoader.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameView.o /Projects/CommitQueue/WebCore/page/FrameView.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (22 failures) Full output: http://queues.webkit.org/results/6975006 The commit-queue encountered the following flaky tests while processing attachment 75944 [details]: fast/loader/recursive-before-unload-crash.html fast/images/load-img-with-empty-src.html Please file bugs against the tests. These tests were authored by beidson@apple.com, eric@webkit.org, and mitz@webkit.org. The commit-queue is continuing to process your patch. Created attachment 76213 [details]
Proposed Patch2
I don't understand why Mac buildbot failed to build WebKit due to this patch.
Anyway, I submitted the patch again.
Attachment 76213 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:568: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 76215 [details]
Proposed Patch3
Fixed the style error.
Comment on attachment 76215 [details] Proposed Patch3 Clearing flags on attachment: 76215 Committed r73751: <http://trac.webkit.org/changeset/73751> All reviewed patches have been landed. Closing bug. |