Bug 50461

Summary:

[v8] Web Inspector: remove duplicate code for capturing stack trace

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys, yutak

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

50560

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch fixing plugin test failures	none

Yury Semikhatsky

Reported 2010-12-03 10:08:23 PST

Web Inspector: remove duplicate code for capturing stack trace

Attachments
Patch (10.79 KB, patch) 2010-12-03 10:10 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (14.43 KB, patch) 2010-12-03 10:46 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch fixing plugin test failures (14.86 KB, patch) 2010-12-06 07:22 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2010-12-03 10:10:40 PST

Created attachment 75505 [details] Patch

Yury Semikhatsky

Comment 2 2010-12-03 10:46:22 PST

Created attachment 75512 [details] Patch

Yury Semikhatsky

Comment 3 2010-12-06 02:17:52 PST

Committed r73351.

Yuta Kitamura

Comment 4 2010-12-06 03:07:45 PST

Hi, This patch seems to cause new crashes in ~10 tests on Chromium canary buildbots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&master=ChromiumWebkit&tests=http%2Ftests%2Fplugins%2Fplugin-document-has-focus.html%2Cplugins%2Fdocument-open.html%2Cplugins%2Fgeturlnotify-during-document-teardown.html%2Cplugins%2Fnetscape-plugin-map-data-to-src.html%2Cplugins%2Fnetscape-plugin-setwindow-size-2.html%2Cplugins%2Fnetscape-plugin-setwindow-size.html%2Cplugins%2Fopen-and-close-window-with-plugin.html%2Cplugins%2Fwindow-open.html Stack trace looks like: [11686:11686:4179036940080:ERROR:base/process_util_posix.cc(106)] Received signal 11 base::debug::StackTrace::StackTrace() [0x81173f9] base::(anonymous namespace)::StackDumpSignalHandler() [0x8104769] 0x4001c420 WebCore::Console::log() [0x8919db2] WebCore::ConsoleInternal::logCallback() [0x8539485] v8::internal::Builtin_HandleApiCall() [0x81b34a1] I'm going to roll out this change if I do not hear from you in next one hour. I appreciate your cooperation.

Yuta Kitamura

Comment 5 2010-12-06 04:21:47 PST

This patch was rolled out at r73355 and the bots are getting back to normal. Reopening this bug for the record. Thanks!

Yury Semikhatsky

Comment 6 2010-12-06 07:22:47 PST

Created attachment 75693 [details] Patch fixing plugin test failures

Yury Semikhatsky

Comment 7 2010-12-06 07:40:37 PST

Committed r73366

Note You need to log in before you can comment on or make changes to this bug.