Summary: | Fix testcase: textPath cannot be inside another textPath | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cosmin Truta <ctruta> | ||||||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, mdelaney7, rwlbuis, zimmermann | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 47759 | ||||||||||||
Attachments: |
|
Description
Cosmin Truta
2010-11-29 23:12:30 PST
Kindly asking Rob to rebaseline, after removing the last <text> line from testcase. For the record: this was introduced in bug 46460, attachment 70961 [details]. Created attachment 75251 [details] Fixed test and updated expectation files To do in bug 50310: Update the expectation files under platform/mac-leopard/ and platform/chromium-win/ Remove the BUGWK50310 line inside platform/chromium/test_expectations.txt Created attachment 75253 [details]
Fixed test and updated expectation files
Same as before, but slightly beautified.
Created attachment 75254 [details]
Fixed test and updated expectation files
Sync'ed master to avoid the patch failure on platform/chromium/test-expectations.txt
Comment on attachment 75254 [details]
Fixed test and updated expectation files
LGTM, r=me.
Comment on attachment 75254 [details] Fixed test and updated expectation files Rejecting patch 75254 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75254]" exit_code: 2 Last 500 characters of output: ectations.txt Hunk #1 FAILED at 3206. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/platform/mac/svg/custom/text-linking-expected.checksum patching file LayoutTests/platform/mac/svg/custom/text-linking-expected.txt patching file LayoutTests/svg/custom/text-linking.svg Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nikolas Zimmermann', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6748011 Created attachment 75705 [details]
Fixed test and updated expectation files
This was r+'ed and cq+'ed, but failed to commit because test_expectations.txt went out of sync.
Given that I don't have cq+ permissions, could you please do the same on this rebaselined patch?
Comment on attachment 75705 [details]
Fixed test and updated expectation files
OK.
The commit-queue encountered the following flaky tests while processing attachment 75705 [details]: compositing/tiling/huge-layer-resize.html java/lc3/JavaObject/JavaObjectToDouble-001.html Please file bugs against the tests. These tests were authored by ap@webkit.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 75705 [details]: inspector/styles-new-API.html Please file bugs against the tests. These tests were authored by apavlov@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch. Comment on attachment 75705 [details] Fixed test and updated expectation files Clearing flags on attachment: 75705 Committed r73415: <http://trac.webkit.org/changeset/73415> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 75705 [details]: fast/loader/recursive-before-unload-crash.html animations/combo-transform-translate+scale.html Please file bugs against the tests. These tests were authored by beidson@apple.com, cmarrin@apple.com, darin@apple.com, eric@webkit.org, ojan@chromium.org, and pol@apple.com. The commit-queue is continuing to process your patch. |