| Summary: | Simplify make-hash-tools.pl | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | Tools / Tests | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abecsi, commit-queue, dglazkov, eric, ossy, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 49925, 49926 | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2010-11-22 10:15:40 PST
Created attachment 74576 [details]
Patch
Attachment 74576 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/html/DocTypeStrings.gperf', u'WebCore/make-hash-tools.pl', u'WebCore/platform/ColorData.gperf', u'WebCore/platform/HashTools.h']" exit_code: 1
WebCore/platform/HashTools.h:38: mode_if_no_sysid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/HashTools.h:39: mode_if_sysid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/HashTools.h:64: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Total errors found: 3 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 74576 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6347002 Comment on attachment 74576 [details] Patch LGTM on the whole, just a few notes. View in context: https://bugs.webkit.org/attachment.cgi?id=74576&action=review Please do not change the license of HashTools.h file since you move the code from make-hash-tools.pl. > WebCore/platform/HashTools.h:65 > \ No newline at end of file The chromium build should be fixed by adding the missing newline here. (In reply to comment #4) > (From update of attachment 74576 [details]) > Please do not change the license of HashTools.h file since you move the code from make-hash-tools.pl. The problem is, that HashTools.h has no license :-(. If you give me a better one i would be happy to change it. > > WebCore/platform/HashTools.h:65 > > \ No newline at end of file > > The chromium build should be fixed by adding the missing newline here. I saw it too late for r?, but will change it before commit. (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 74576 [details] [details]) > > Please do not change the license of HashTools.h file since you move the code from make-hash-tools.pl. > The problem is, that HashTools.h has no license :-(. If you give me a better one i would be happy to change it. I see, the generated HashTools.h has no license, but the code you moved was in make-hash-tools.pl, which has LGPL license. Created attachment 74649 [details] Patch (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 74576 [details] [details] [details]) > > > Please do not change the license of HashTools.h file since you move the code from make-hash-tools.pl. > > The problem is, that HashTools.h has no license :-(. If you give me a better one i would be happy to change it. > > I see, the generated HashTools.h has no license, but the code you moved was in make-hash-tools.pl, which has LGPL license. Uuups, missed that. Sorry! Attachment 74649 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/html/DocTypeStrings.gperf', u'WebCore/make-hash-tools.pl', u'WebCore/platform/ColorData.gperf', u'WebCore/platform/HashTools.h']" exit_code: 1
WebCore/platform/HashTools.h:33: mode_if_no_sysid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/HashTools.h:34: mode_if_sysid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The commit-queue encountered the following flaky tests while processing attachment 74649 [details]: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. Comment on attachment 74649 [details] Patch Clearing flags on attachment: 74649 Committed r72664: <http://trac.webkit.org/changeset/72664> All reviewed patches have been landed. Closing bug. This change causes HashTools to no longer be tracked for dependency changes. The Xcode project, for example, is missing HashTools.h. I encountered this because my laptop hadn't built in a long time and had an old copy of HashTools.h in the DerivedSources folder (which for whatever reason didn't seem to be cleared on a clean build?). Eventually I found and deleted that HashTools.h and my build worked, but it would have worked sooner if the build systems had been educated about the new location of HashTools.h. :) Committed r74764: <http://trac.webkit.org/changeset/74764> |