Bug 49641

Summary:

Add support for lower-armenian and upper-armenian

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

48000

Attachments:

Description	Flags
Work-in-progress patch	none
Patch with test cases	none
Patch with test cases	none

Description Daniel Bates 2010-11-16 21:13:56 PST

We should add the list-style-types lower-armenian and upper-armenian for lowercase Armenian and uppercase Armenian numerals, respectively.

Comment 1 Daniel Bates 2010-11-16 21:22:56 PST

Created attachment 74081 [details]
Work-in-progress patch

Work-in-progress patch. Needs change log.

Comment 2 Daniel Bates 2010-12-03 12:04:15 PST

Created attachment 75524 [details]
Patch with test cases

Spoke with Richard Ishida on IRC on 11/30/2010 and he confirmed that we can use derived test cases from <http://www.w3.org/International/tests/tests-html-css/list-lists> under the W3C Test Suite License (BSD). And this patch includes two test cases derived from the test case W3C test case "upper-armenian, up to 9,999".

Comment 3 Daniel Bates 2010-12-03 12:09:02 PST

(In reply to comment #2)
> Created an attachment (id=75524) [details]
> Patch with test cases
> 
> Spoke with Richard Ishida on IRC on 11/30/2010 and he confirmed that we can use derived test cases from <http://www.w3.org/International/tests/tests-html-css/list-lists> under the W3C Test Suite License (BSD). And this patch includes two test cases derived from the test case W3C test case "upper-armenian, up to 9,999".

I meant to say the test cases were derived from the W3C test case "lower-armenian, up to 9,999" and "upper-armenian, up to 9,999".

Comment 4 Daniel Bates 2010-12-03 12:09:51 PST

Created attachment 75525 [details]
Patch with test cases

Minor gramatical correction in test case.

Comment 5 Daniel Bates 2010-12-04 21:12:32 PST

Comment on attachment 75525 [details]
Patch with test cases

Clearing flags on attachment: 75525

Committed r73338: <http://trac.webkit.org/changeset/73338>

Comment 6 Daniel Bates 2010-12-04 21:12:39 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Daniel Bates 2010-12-04 23:29:02 PST

For completeness, committed updated test case for fast/lists/w3-css3-list-styles-fallback-style.html and rebased result in changeset 73339 <http://trac.webkit.org/changeset/73339> and changeset 73340 <http://trac.webkit.org/changeset/73340>, respectively.