Bug 49641 – Add support for lower-armenian and upper-armenian

Bug 49641 - Add support for lower-armenian and upper-armenian


Summary:	Add support for lower-armenian and upper-armenian

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc.
Version:	528+ (Nightly build)
Platform:	PC All

Importance:	P2 Normal
Assigned To:	Daniel Bates

URL:
Keywords:

Depends on:
Blocks:	48000
	Show dependency tree / graph

Reported:	2010-11-16 21:13 PST by Daniel Bates
Modified:	2010-12-04 23:29 PST (History)
CC List:	2 users (show)

See Also:

Attachments
Work-in-progress patch (13.61 KB, patch) 2010-11-16 21:22 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch with test cases (21.50 KB, patch) 2010-12-03 12:04 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch with test cases (21.50 KB, patch) 2010-12-03 12:09 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Bates 2010-11-16 21:13:56 PST

We should add the list-style-types lower-armenian and upper-armenian for lowercase Armenian and uppercase Armenian numerals, respectively.

Comment 1 Daniel Bates 2010-11-16 21:22:56 PST

Created attachment 74081 [details]
Work-in-progress patch

Work-in-progress patch. Needs change log.

Comment 2 Daniel Bates 2010-12-03 12:04:15 PST

Created attachment 75524 [details]
Patch with test cases

Spoke with Richard Ishida on IRC on 11/30/2010 and he confirmed that we can use derived test cases from <http://www.w3.org/International/tests/tests-html-css/list-lists> under the W3C Test Suite License (BSD). And this patch includes two test cases derived from the test case W3C test case "upper-armenian, up to 9,999".

Comment 3 Daniel Bates 2010-12-03 12:09:02 PST

(In reply to comment #2)
> Created an attachment (id=75524) [details]
> Patch with test cases
> 
> Spoke with Richard Ishida on IRC on 11/30/2010 and he confirmed that we can use derived test cases from <http://www.w3.org/International/tests/tests-html-css/list-lists> under the W3C Test Suite License (BSD). And this patch includes two test cases derived from the test case W3C test case "upper-armenian, up to 9,999".

I meant to say the test cases were derived from the W3C test case "lower-armenian, up to 9,999" and "upper-armenian, up to 9,999".

Comment 4 Daniel Bates 2010-12-03 12:09:51 PST

Created attachment 75525 [details]
Patch with test cases

Minor gramatical correction in test case.

Comment 5 Daniel Bates 2010-12-04 21:12:32 PST

Comment on attachment 75525 [details]
Patch with test cases

Clearing flags on attachment: 75525

Committed r73338: <http://trac.webkit.org/changeset/73338>

Comment 6 Daniel Bates 2010-12-04 21:12:39 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Daniel Bates 2010-12-04 23:29:02 PST

For completeness, committed updated test case for fast/lists/w3-css3-list-styles-fallback-style.html and rebased result in changeset 73339 <http://trac.webkit.org/changeset/73339> and changeset 73340 <http://trac.webkit.org/changeset/73340>, respectively.