| Summary: | check-webkit-style function detection doesn't detect indented functions declaractions. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Levin <levin> | ||||||||
| Component: | Tools / Tests | Assignee: | David Levin <levin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, cjerdonek, commit-queue, eric, hamaji | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 49394 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
David Levin
2010-11-12 07:58:53 PST
Created attachment 73744 [details]
Patch
Created attachment 73746 [details]
Patch
Comment on attachment 73746 [details]
Patch
Whoops, I meant cq? not cq+.
Comment on attachment 73746 [details] Patch Rejecting patch 73746 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: tTools/Scripts/webkitpy/style/checkers/cpp.py", line 1211, in check_for_function_lengths ending_line_number = close_expression(clean_lines, start_line_number, open_brace_index)[1] File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/style/checkers/cpp.py", line 643, in close_expression line = clean_lines.elided[line_number] IndexError: list index out of range ---------------------------------------------------------------------- Ran 692 tests in 8.902s FAILED (errors=8) Full output: http://queues.webkit.org/results/5753022 Comment on attachment 73746 [details]
Patch
Tests don't pass.
Created attachment 73752 [details]
Patch
Comment on attachment 73752 [details]
Patch
Looks good.
Comment on attachment 73752 [details] Patch Rejecting patch 73752 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73752]" exit_code: 2 Last 500 characters of output: succeeded at 612 (offset 1 line). Hunk #3 succeeded at 622 (offset 1 line). Hunk #4 succeeded at 639 (offset 1 line). Hunk #5 succeeded at 1174 (offset 1 line). Hunk #6 FAILED at 1210. 1 out of 6 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/checkers/cpp.py.rej patching file WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6020030 Committed as http://trac.webkit.org/changeset/71976 |