Bug 49284

Summary: SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dino, eric, mdelaney7, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41761    
Attachments:
Description Flags
calcMode="spline" from-to-animation
none
Patch zimmermann: review+

Dirk Schulze
Reported 2010-11-09 14:49:59 PST
SVG animations should use from-to-by animations as some kind of fallback, if a values list is not specified. The specification goes a bit more into detail about spline but it's still necessary to investigate what other viewers are doing. See last two paragraphs in http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationKeysplines
Attachments
calcMode="spline" from-to-animation (468 bytes, image/svg+xml)
2010-11-09 14:51 PST, Dirk Schulze 		no flags
Details
Patch (31.97 KB, patch)
2010-11-11 06:47 PST, Dirk Schulze 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-11-09 14:51:13 PST
Created attachment 73424 [details] calcMode="spline" from-to-animation
Dirk Schulze
Comment 2 2010-11-11 06:47:49 PST
Created attachment 73607 [details] Patch
Nikolas Zimmermann
Comment 3 2010-11-11 06:54:06 PST
Comment on attachment 73607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73607&action=review Tests look great, please change bug title and clarify changelog, r=me. > WebCore/ChangeLog:5 > + SVGAnimation calcMode="spline" should use 'to' 'by' animation if no values were specified The bug title is unclear, wheter you mean 'to-by' animation or 'to or by animation'. > WebCore/ChangeLog:8 > + Add support for from-to-by animations in combination with calcMode 'spline' for SVGAnimations. from-to-by? you mean from-to / from-by ? > WebCore/svg/SVGAnimationElement.cpp:515 > unsigned num = m_keySplines.size() + 1; s/num/splinesCount/ ?
Dirk Schulze
Comment 4 2010-11-11 09:27:19 PST
Committed r71828: <http://trac.webkit.org/changeset/71828>
Dirk Schulze
Comment 5 2010-11-11 09:42:14 PST
Committed r71830: <http://trac.webkit.org/changeset/71830>
WebKit Review Bot
Comment 6 2010-11-11 10:42:52 PST
http://trac.webkit.org/changeset/71828 might have broken Leopard Intel Release (Tests) The following tests are not passing: media/video-played-collapse.html media/video-played-ranges-1.html media/video-played-reset.html
WebKit Review Bot
Comment 7 2010-11-11 10:43:06 PST
http://trac.webkit.org/changeset/71830 might have broken Leopard Intel Release (Tests) The following tests are not passing: media/video-played-collapse.html media/video-played-ranges-1.html media/video-played-reset.html
Note You need to log in before you can comment on or make changes to this bug.