Bug 49230

Summary: Philip Canvas test 2d.pattern.image.incomplete fails
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, excors, mdelaney7, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://philip.html5.org/tests/canvas/suite/tests/2d.pattern.image.incomplete.html
Bug Depends on:    
Bug Blocks: 46506    
Description Flags
Patch none

Description Helder Correia 2010-11-08 18:11:59 PST
The test should be modified in the same way as 2d.drawImage.incomplete.  See https://bugs.webkit.org/show_bug.cgi?id=48306.
Comment 1 Helder Correia 2010-11-08 18:15:36 PST
Created attachment 73327 [details]
Comment 2 Andreas Kling 2010-11-09 01:02:23 PST
Comment on attachment 73327 [details]

Comment 3 WebKit Commit Bot 2010-11-09 03:33:12 PST
Comment on attachment 73327 [details]

Rejecting patch 73327 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
canvas/philip/tests/2d.pattern.image.incomplete.html -> failed

Exiting early after 1 failures. 653 tests run.
21.28s total testing time

652 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
2 test cases (<1%) had stderr output

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd']" exit_code: 1

2 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/5445048
Comment 4 Helder Correia 2010-11-09 14:50:49 PST
(In reply to comment #3)
> (From update of attachment 73327 [details])
> Rejecting patch 73327 from commit-queue.

Any idea why the test failed? It passes just fine on my machine.
Comment 5 Helder Correia 2010-11-09 15:15:47 PST
(In reply to comment #4)
> Any idea why the test failed? It passes just fine on my machine.

My bad, I need to change 2d.pattern.image.incomplete-expected.txt.
Comment 6 Helder Correia 2010-11-09 15:28:49 PST
Created attachment 73431 [details]
Comment 7 Matthew Delaney 2010-11-09 16:33:11 PST
There's no need to leave the snow-leopard expected results file. You can blow that file away and then run-webkit-tests will compare the results against the top-level expected results file (that should be passing as well).

Also, if you cc some of the other ports' canvas-concerned people on these sorts of bugs then they'll be aware that these tests may now be passing on their ports and thus they can unskip the tests (assuming they've skipped them).
Comment 8 Helder Correia 2010-11-09 17:31:37 PST
Created attachment 73444 [details]
Comment 9 WebKit Commit Bot 2010-11-09 21:41:49 PST
Comment on attachment 73444 [details]

Clearing flags on attachment: 73444

Committed r71718: <http://trac.webkit.org/changeset/71718>
Comment 10 WebKit Commit Bot 2010-11-09 21:41:54 PST
All reviewed patches have been landed.  Closing bug.