Bug 48894 – Fix canvas/philip/tests/2d.pattern.image.undefined.html

• Component: Canvas
• Status: RESOLVED FIXED

[Matthew Delaney]

Another test where we're just not throwing the right error code.

[Matthew Delaney]

Created attachment 72794 [details]
Patch

[Andreas Kling]

Comment on attachment 72794 [details]
Patch

You should remove the test from the skiplists in this patch (currently skipped on gtk, mac-leopard and qt.)

Also, this is basically a dup of bug 37177.

[Matthew Delaney]

Created attachment 72840 [details]
Patch

[Darin Adler]

Comment on attachment 72840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72840&action=review

The test cases cover passing non-objects, but not passing objects of the wrong type, which follows a different code path. I’d like to see tests covering all the code changes?

What about drawImageFromRect?

> WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:272
> -    } else
> -       return throwTypeError(exec);
> -    
> +    }
> +    setDOMException(exec, TYPE_MISMATCH_ERR);

This change looks wrong. It seems we will set the exception in cases where we succeeded above. After those cases break out of their switch statements and then fall out of the if statements.

Do we have test cases covering those? Are they failing with exceptions now? If not, why not?

[Matthew Delaney]

Sorry about that, I muddled together two patches. The correct split up patches are coming now.

[Matthew Delaney]

Created attachment 72846 [details]
Patch

[Matthew Delaney]

Committed r71268: <http://trac.webkit.org/changeset/71268>

[WebKit Review Bot]

http://trac.webkit.org/changeset/71268 might have broken Qt Linux Release
The following tests are not passing:
svg/in-html/by-reference.html
svg/in-html/circle.html
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
svg/text/foreignObject-text-clipping-bug.xml
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml

[Csaba Osztrogonác]

(In reply to comment #8)
> http://trac.webkit.org/changeset/71268 might have broken Qt Linux Release
> The following tests are not passing:
> svg/in-html/by-reference.html
> svg/in-html/circle.html
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
> svg/text/foreignObject-text-clipping-bug.xml
> svg/text/selection-background-color.xhtml
> svg/text/selection-styles.xhtml
> svg/zoom/page/zoom-coords-viewattr-01-b.svg
> svg/zoom/page/zoom-hixie-mixed-008.xml
> svg/zoom/page/zoom-hixie-mixed-009.xml
> svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
> svg/zoom/page/zoom-svg-float-border-padding.xml

Sorry for SPAM. 

New bug report filed: https://bugs.webkit.org/show_bug.cgi?id=48958