Bug 48486

Summary: [GTK] Move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gns, webkit.review.bot, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 47836    
Bug Blocks:    
Attachments:
Description Flags
Patch for this issue
none
Patch with slightly different design none

Description Martin Robinson 2010-10-27 17:16:22 PDT
We want to move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk, which an important step in moving away from the Mozilla theme drawing code and fixing menu list rendering.
Comment 1 Martin Robinson 2010-10-27 18:29:52 PDT
Created attachment 72125 [details]
Patch for this issue
Comment 2 WebKit Review Bot 2010-10-27 18:31:32 PDT
Attachment 72125 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/gtk/RenderThemeGtk.cpp:473:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2010-10-27 18:35:06 PDT
(In reply to comment #2)
> If any of these errors are false positives, please file a bug against check-webkit-style.

This is a false positive. We need to add an exception for gtk_widget_style_get.
Comment 4 WebKit Review Bot 2010-10-28 20:08:59 PDT
Attachment 72125 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4748081
Comment 5 Martin Robinson 2010-11-02 22:06:43 PDT
Created attachment 72789 [details]
Patch with slightly different design
Comment 6 WebKit Review Bot 2010-11-02 22:08:13 PDT
Attachment 72789 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/gtk/RenderThemeGtk.cpp']" exit_code: 1
WebCore/platform/gtk/RenderThemeGtk.cpp:473:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2010-11-04 09:45:32 PDT
Attachment 72789 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/5164016
Comment 8 Gustavo Noronha (kov) 2010-12-06 04:58:05 PST
Comment on attachment 72789 [details]
Patch with slightly different design

This one looks right to me, now I'll review the one it depends on (doh).
Comment 9 Eric Seidel (no email) 2010-12-14 15:14:49 PST
Attachment 72789 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.
Comment 10 Eric Seidel (no email) 2010-12-20 22:58:25 PST
r74132.  Please close your bugs after landing. :)
Comment 11 Martin Robinson 2010-12-20 23:09:00 PST
Comment on attachment 72789 [details]
Patch with slightly different design

Sorry. Will try to be better about this in the future.