| Summary: | Warning when compiling the chromium port of DumpRenderShell with clang | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Søren Gjesse <sgjesse> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Trivial | CC: | commit-queue, ctruta, hans | ||||||
| Priority: | P5 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Looks good to me, but I am not a reviewer. Looking closer, shouldn't the ChangeLog contain a link to this bug entry? I thought the tools put that in automatically... Created attachment 72304 [details]
Patch
Comment on attachment 72304 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 72304 [details]: http/tests/cache/subresource-expiration.html Please file bugs against the tests. These tests were authored by koivisto@iki.fi. The commit-queue is continuing to process your patch. Comment on attachment 72304 [details] Patch Clearing flags on attachment: 72304 Committed r71030: <http://trac.webkit.org/changeset/71030> All reviewed patches have been landed. Closing bug. |
Created attachment 72010 [details] Simple patch Method javaScriptFlagsForLoad in TestShell.h compares a size_t argument >= 0 which causes a warning in clang