Bug 47855

Summary:

Deploy Queue class in more places throughout QueueStatusServer

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dpranke, eric, mihaip, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

47847

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	commit-queue: commit-queue-

Eric Seidel (no email)

Reported 2010-10-18 15:42:40 PDT

Deploy Queue class in more places throughout QueueStatusServer

Attachments
Patch (14.79 KB, patch) 2010-10-18 15:44 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (14.80 KB, patch) 2010-10-18 16:06 PDT, Eric Seidel (no email)	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-10-18 15:44:57 PDT

Created attachment 71095 [details] Patch

Adam Barth

Comment 2 2010-10-18 15:55:08 PDT

Comment on attachment 71095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71095&action=review > WebKitTools/QueueStatusServer/model/workitems.py:39 > + def position_for_attachment(self, attachment_id): index_of_attachment

Eric Seidel (no email)

Comment 3 2010-10-18 16:06:28 PDT

Created attachment 71097 [details] Patch for landing

WebKit Commit Bot

Comment 4 2010-10-18 16:10:53 PDT

Comment on attachment 71097 [details] Patch for landing Rejecting patch 71097 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71097]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=71097&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47855&ctype=xml Processing 1 patch from 1 bug. Processing patch 71097 from bug 47855. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4446076

Eric Seidel (no email)

Comment 5 2010-10-18 17:16:51 PDT

Comment on attachment 71097 [details] Patch for landing I forget that we have a cluster of commit-queues now and I can't post dependent patches as easily.

WebKit Commit Bot

Comment 6 2010-10-18 17:17:58 PDT

Comment on attachment 71097 [details] Patch for landing Rejecting patch 71097 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71097]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=71097&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47855&ctype=xml Processing 1 patch from 1 bug. Processing patch 71097 from bug 47855. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4438087

Eric Seidel (no email)

Comment 7 2010-10-18 19:13:41 PDT

Committed r70016: <http://trac.webkit.org/changeset/70016>

WebKit Review Bot

Comment 8 2010-10-18 20:05:51 PDT

http://trac.webkit.org/changeset/70016 might have broken Leopard Intel Release (Tests) The following tests are not passing: media/video-zoom.html

Note You need to log in before you can comment on or make changes to this bug.