Bug 47847

Summary: Add Queue class and add minimal unittesting of QueueStatusServer code
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47855    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-10-18 14:12:37 PDT
Add Queue class and add minimal unittesting of QueueStatusServer code
Attachments
Patch (23.74 KB, patch)
2010-10-18 14:20 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-10-18 14:20:51 PDT
Created attachment 71081 [details] Patch
Adam Barth
Comment 2 2010-10-18 14:28:57 PDT
Comment on attachment 71081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71081&action=review 404! > WebKitTools/QueueStatusServer/model/queues.py:73 > + def short_name(self): > + # HACK: chromium-ews is incorrectly named. > + short_name = self._name.replace("chromium-ews", "Cr-Linux-ews") > + short_name = short_name.replace("-ews", "") > + short_name = short_name.replace("-queue", "") > + return self._caplitalize_after_dash(short_name.capitalize()) This is all ridiculous.
Eric Seidel (no email)
Comment 3 2010-10-18 15:48:30 PDT
(In reply to comment #2) > > WebKitTools/QueueStatusServer/model/queues.py:73 > > + def short_name(self): > > + # HACK: chromium-ews is incorrectly named. > > + short_name = self._name.replace("chromium-ews", "Cr-Linux-ews") > > + short_name = short_name.replace("-ews", "") > > + short_name = short_name.replace("-queue", "") > > + return self._caplitalize_after_dash(short_name.capitalize()) > > This is all ridiculous. It's just there to match the previous manual array mapping from one to the other.
WebKit Commit Bot
Comment 4 2010-10-18 16:04:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 71081 [details]: fast/dom/HTMLScriptElement/script-set-src.html Please file bugs against the tests. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-10-18 16:09:04 PDT
Comment on attachment 71081 [details] Patch Clearing flags on attachment: 71081 Committed r70006: <http://trac.webkit.org/changeset/70006>
WebKit Commit Bot
Comment 6 2010-10-18 16:09:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2010-10-18 16:11:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 71081 [details]: http/tests/websocket/tests/close-on-unload-reference-in-parent.html Please file bugs against the tests. The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.