Bug 47847

Summary: Add Queue class and add minimal unittesting of QueueStatusServer code
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, mihai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47855    
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-10-18 14:12:37 PDT
Add Queue class and add minimal unittesting of QueueStatusServer code
Comment 1 Eric Seidel (no email) 2010-10-18 14:20:51 PDT
Created attachment 71081 [details]
Patch
Comment 2 Adam Barth 2010-10-18 14:28:57 PDT
Comment on attachment 71081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71081&action=review

404!

> WebKitTools/QueueStatusServer/model/queues.py:73
> +    def short_name(self):
> +        # HACK: chromium-ews is incorrectly named.
> +        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
> +        short_name = short_name.replace("-ews", "")
> +        short_name = short_name.replace("-queue", "")
> +        return self._caplitalize_after_dash(short_name.capitalize())

This is all ridiculous.
Comment 3 Eric Seidel (no email) 2010-10-18 15:48:30 PDT
(In reply to comment #2)
> > WebKitTools/QueueStatusServer/model/queues.py:73
> > +    def short_name(self):
> > +        # HACK: chromium-ews is incorrectly named.
> > +        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
> > +        short_name = short_name.replace("-ews", "")
> > +        short_name = short_name.replace("-queue", "")
> > +        return self._caplitalize_after_dash(short_name.capitalize())
> 
> This is all ridiculous.

It's just there to match the previous manual array mapping from one to the other.
Comment 4 WebKit Commit Bot 2010-10-18 16:04:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 71081 [details]:

fast/dom/HTMLScriptElement/script-set-src.html

Please file bugs against the tests.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-10-18 16:09:04 PDT
Comment on attachment 71081 [details]
Patch

Clearing flags on attachment: 71081

Committed r70006: <http://trac.webkit.org/changeset/70006>
Comment 6 WebKit Commit Bot 2010-10-18 16:09:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2010-10-18 16:11:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 71081 [details]:

http/tests/websocket/tests/close-on-unload-reference-in-parent.html

Please file bugs against the tests.  The commit-queue is continuing to process your patch.