Bug 47792

Summary:

dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

morrita, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

43017

Attachments:

Description	Flags
converts tests	none
converts tests	none
converts tests	none
fixed per tkent's comments	tkent: review+, tkent: commit-queue-

Description Ryosuke Niwa 2010-10-17 21:56:37 PDT

The following tests should be converted to dump-as-markup tests:
editing/execCommand/remove-formatting.html
editing/execCommand/remove-formatting-2.html

Comment 1 Ryosuke Niwa 2010-10-17 22:22:15 PDT

Created attachment 70996 [details]
converts tests

Comment 2 Ryosuke Niwa 2010-10-17 22:28:03 PDT

Created attachment 70997 [details]
converts tests

Comment 3 Ryosuke Niwa 2010-10-17 22:31:19 PDT

Created attachment 70998 [details]
converts tests

Comment 4 Kent Tamura 2010-10-17 22:40:54 PDT

Comment on attachment 70998 [details]
converts tests

View in context: https://bugs.webkit.org/attachment.cgi?id=70998&action=review

> LayoutTests/editing/execCommand/remove-formatting.html:15
> +    layoutTestController.dumpAsText();

No need to call dumpAsText().  dump-as-markup.js calls it.

> LayoutTests/platform/qt/editing/execCommand/remove-formatting-expected.txt:-25
> -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

This sequence of editing callbacks looks different from other ports.  Is it safe to remove this?

Comment 5 Ryosuke Niwa 2010-10-17 22:52:48 PDT

(In reply to comment #4)
> (From update of attachment 70998 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70998&action=review
> 
> > LayoutTests/editing/execCommand/remove-formatting.html:15
> > +    layoutTestController.dumpAsText();
> 
> No need to call dumpAsText().  dump-as-markup.js calls it.

Oops, will fix.

> > LayoutTests/platform/qt/editing/execCommand/remove-formatting-expected.txt:-25
> > -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> 
> This sequence of editing callbacks looks different from other ports.  Is it safe to remove this?

Mn... we might need to add platform-specific results later then.

Comment 6 Ryosuke Niwa 2010-10-18 11:38:47 PDT

Created attachment 71066 [details]
fixed per tkent's comments

Comment 7 Kent Tamura 2010-10-18 21:56:17 PDT

Comment on attachment 71066 [details]
fixed per tkent's comments

ok.
Please take care of Qt bot after committing this.

Comment 8 Ryosuke Niwa 2010-10-18 23:34:36 PDT

Committed r70031: <http://trac.webkit.org/changeset/70031>