Bug 47784

Summary:

dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

morrita, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

43017

Attachments:

Description	Flags
converted tests	tkent: review+

Ryosuke Niwa

Reported 2010-10-17 15:22:30 PDT

The following tests should be converted to dump-as-markup tests: editing/execCommand/4920742-1.html editing/execCommand/5049671.html editing/execCommand/5573879.html

Attachments
converted tests (29.97 KB, patch) 2010-10-17 16:11 PDT, Ryosuke Niwa	tkent: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2010-10-17 16:11:05 PDT

Created attachment 70987 [details] converted tests

Kent Tamura

Comment 2 2010-10-17 22:31:31 PDT

Comment on attachment 70987 [details] converted tests ok. BTW, I don't like number-only test names. Probably names like remove-format-5049671.html is better.

Ryosuke Niwa

Comment 3 2010-10-17 22:51:04 PDT

Thanks for the review! (In reply to comment #2) > (From update of attachment 70987 [details]) > ok. > BTW, I don't like number-only test names. Probably names like remove-format-5049671.html is better. yeah, I think all new tests are given more descriptive file names.

Ryosuke Niwa

Comment 4 2010-10-18 12:14:26 PDT

Committed r69982: <http://trac.webkit.org/changeset/69982>

Note You need to log in before you can comment on or make changes to this bug.