Summary: | [Qt] AC rendering bugs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Girish Ramakrishnan <girish> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ademar, christian.webkit, commit-queue, eric, hausmann, noam, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 35524 | ||||||||
Attachments: |
|
Description
Girish Ramakrishnan
2010-10-12 22:01:35 PDT
Created attachment 71030 [details]
Patch for the scroll issue
Created attachment 71031 [details]
Patch: second rendering bug (clicking a plugin)
Comment on attachment 71030 [details]
Patch for the scroll issue
LGTM.
Comment on attachment 71031 [details] Patch: second rendering bug (clicking a plugin) View in context: https://bugs.webkit.org/attachment.cgi?id=71031&action=review LGTM. > WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:864 > + return; Nit: "break;" would fit better in this context. The scroll patch breaks youtube for me (scrolls fine but nothing renders). Patches rebased over r69947 Scrolling works after applying both patches. Can we commit them as a single patch (or split them correctly?) Err, sorry for the confusion. I had some patches before noam's patches. All good, commit in any order. Comment on attachment 71030 [details] Patch for the scroll issue Clearing flags on attachment: 71030 Committed r69966: <http://trac.webkit.org/changeset/69966> Comment on attachment 71031 [details] Patch: second rendering bug (clicking a plugin) Clearing flags on attachment: 71031 Committed r69971: <http://trac.webkit.org/changeset/69971> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/69971 might have broken Qt Windows 32-bit Release |