Bug 47485 – SubframeLoader should call setNeedsStyleRecalc() after creating plugin

• Component: Plug-ins
• Status: RESOLVED INVALID

[Girish Ramakrishnan]

RenderLayerCompositor uses setNeedsStyleRecalc() to trigger acclerated compositing layers. This change is a precursor to adding accelerated compositing support for NPAPI plugins.

See 35524 for AC support for NPAPI plugins in Qt.

[Girish Ramakrishnan]

Created attachment 70428 [details]
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING)

[Simon Fraser (smfr)]

Comment on attachment 70428 [details]
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING)

View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review

> WebCore/loader/SubframeLoader.cpp:371
>      pluginElement->setNeedsStyleRecalc(SyntheticStyleChange);

Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same?

[Girish Ramakrishnan]

(In reply to comment #2)
> (From update of attachment 70428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review
> 
> > WebCore/loader/SubframeLoader.cpp:371
> >      pluginElement->setNeedsStyleRecalc(SyntheticStyleChange);
> 
> Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same?

Indeed. It is indeed better to make this platform specific since one needs to let the compositor know only if AC is supported by the Chrome and WebKit port supports AC for plugins in that chrome.