Bug 47380

Summary: [V8] Add FileWriter to active DOM map
Product: WebKit Reporter: Eric U. <ericu>
Component: DOMAssignee: Eric U. <ericu>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, jianli, kinuko, michaeln
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 44358    
Attachments:
Description Flags
One-liner.
jianli: review-
Fixed ChangeLog and bug title. none

Description Eric U. 2010-10-07 14:28:54 PDT 
As in https://bugs.webkit.org/show_bug.cgi?id=47205, it needs to be added in CodeGeneratorV8.pm.
However, it's not directly constructable, so it doesn't need the custom constructor.  The ref() is done in wrapSlow(), which gets called via FileWriterCallback.
Comment 1 Eric U. 2010-10-07 17:58:42 PDT 
Created attachment 70181 [details]
One-liner.

Hope this works; I haven't created a patch manually on Windows before.
Comment 2 Jian Li 2010-10-07 18:02:06 PDT 
Comment on attachment 70181 [details]
One-liner.

View in context: https://bugs.webkit.org/attachment.cgi?id=70181&action=review

> WebCore/ChangeLog:5
> +        Add FileWriter to V8 active DOM map

Please add "[V8]" prefix to the bug title and also update the ChangeLog.
Comment 3 Eric U. 2010-10-07 18:27:10 PDT 
Created attachment 70183 [details]
Fixed ChangeLog and bug title.
Comment 4 WebKit Commit Bot 2010-10-07 19:03:28 PDT 
Comment on attachment 70183 [details]
Fixed ChangeLog and bug title.

Clearing flags on attachment: 70183

Committed r69370: <http://trac.webkit.org/changeset/69370>
Comment 5 WebKit Commit Bot 2010-10-07 19:03:33 PDT 
All reviewed patches have been landed.  Closing bug.