Bug 47098

Summary: dump-as-markup conversion: editing/execCommand/format-block-with-braces.html and format-block.html
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 19795    
Attachments:
Description Flags
Patch
none
Patch
none
Patch tony: review+

Ryosuke Niwa
Reported 2010-10-04 11:26:37 PDT
editing/execCommand/format-block.html should be converted to a dump-as-markup test since it's testing the DOM modifications done by execCommand("FormatBlock");
Attachments
Patch (18.09 KB, patch)
2010-10-04 11:55 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (39.86 KB, patch)
2010-10-04 12:13 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (39.31 KB, patch)
2010-10-04 12:18 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-10-04 11:55:03 PDT
Created attachment 69657 [details] Patch
Ryosuke Niwa
Comment 2 2010-10-04 12:01:57 PDT
editing/execCommand/format-block-with-braces.html should be converted as well.
Ryosuke Niwa
Comment 3 2010-10-04 12:13:00 PDT
Created attachment 69662 [details] Patch
Ryosuke Niwa
Comment 4 2010-10-04 12:18:59 PDT
Created attachment 69666 [details] Patch
Tony Chang
Comment 5 2010-10-04 15:05:35 PDT
Comment on attachment 69666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69666&action=review > LayoutTests/editing/execCommand/format-block-with-braces.html:3 > +<!DOCTYPE html> > +<html> > +<body> I don't know if we have a policy on whether tests should have doctype, html or body tags. I think on webkit-dev mjs said he likes the <!DOCTYPE html> tag because we want to be testing the standards compliant parser. That said, since this is an existing test and it didn't have these tags originally, I kind of think the test should not have these tags (i.e., it's more like a regression test). I don't have a strong opinion one way or another and it shouldn't matter at all for this test, so either is fine with me.
Ryosuke Niwa
Comment 6 2010-10-05 14:38:05 PDT
Committed r69147: <http://trac.webkit.org/changeset/69147>
Note You need to log in before you can comment on or make changes to this bug.