| Summary: | Update Angle interface from 100 to 101 for chromium --in-process-webgl | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||||||
| Component: | WebGL | Assignee: | Alok Priyadarshi <alokp> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, enne, kbr, senorblanco, webkit.review.bot, zmo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 69701 [details]
proposed patch
Attachment 69701 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:1423: One space before end of line comments [whitespace/comments] [5]
WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:1446: One space before end of line comments [whitespace/comments] [5]
WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:1490: One space before end of line comments [whitespace/comments] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 69708 [details]
proposed patch
Fixed style issues.
Comment on attachment 69708 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=69708&action=review This generally looks good. One minor formatting comment; please fix and submit a new patch. Also, please file a bug about updating the version of ANGLE checked in to WebKit. It would be really helpful if you could update that version as well so that Safari and Chromium stay in sync. > WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:1426 > + &resources.MaxVertexUniformVectors); There's no 80-column limit in the WebKit coding style. I think these looked cleaner as one-line expressions. Please re-format them. Created attachment 69805 [details]
proposed patch
Fixed formatting as suggested.
Comment on attachment 69805 [details]
proposed patch
Looks good to me.
Comment on attachment 69805 [details] proposed patch Clearing flags on attachment: 69805 Committed r69139: <http://trac.webkit.org/changeset/69139> All reviewed patches have been landed. Closing bug. |
Need to have support for Angle 100 and 101 at the same time until Chromium DEPS roll angle to 101. The code that's been affected is in ${WebKitRoot}/WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp functions angleCreateCompilers angleValidateShaderSource()