Bug 46525 – When animations are paused, play-state can cause them to be unpaused.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Load LayoutTests/animations/play-state.html, and just after the animation starts, pause animations. Note how the animations automatically resume when play-state changes.

[Simon Fraser (smfr)]

<rdar://problem/8476959>

[Chris Marrin]

Created attachment 72698 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 72698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72698&action=review

> WebCore/ChangeLog:10
> +        "running" and not suspended. Likewise pauses animation when either
> +        flag is in the right state,

There's an incomplete sentence here.

> WebCore/page/animation/AnimationBase.cpp:1214
> +    bool wantToBePaused = playState == AnimPlayStatePaused || m_compAnim->suspended();

'wantToBePaused' confuses me. "shouldBePaused", or just "pause" perhaps?

> LayoutTests/animations/play-state-suspend.html:83
> +    runAnimationTest(expectedValues, setTimers, null, true);

Please annotate the parameters, or use variables to make the purposes of  'null' and 'true' clear.

[Chris Marrin]

Made changes suggested by Simon and landed in http://trac.webkit.org/changeset/71161