Bug 46355

Summary:

Fix usage of enum as if it was a define

Product:

WebKit

Reporter:

Lucas De Marchi <lucas.de.marchi>

Component:

JavaScriptCore

Assignee:

Lucas De Marchi <lucas.de.marchi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barbieri, commit-queue, darin, kenneth, ossy, tonikitoo, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Lucas De Marchi

Reported 2010-09-23 08:22:02 PDT

Fix usage of enum as if it was a define

Attachments
Patch (1.57 KB, patch) 2010-09-23 08:29 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Patch (1.85 KB, patch) 2010-09-23 12:06 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Lucas De Marchi

Comment 1 2010-09-23 08:29:04 PDT

Created attachment 68522 [details] Patch

Csaba Osztrogonác

Comment 2 2010-09-23 10:08:51 PDT

Here is a related bug: https://bugs.webkit.org/show_bug.cgi?id=45246 Zoltan, Darin, could you check it?

Darin Adler

Comment 3 2010-09-23 11:41:09 PDT

Comment on attachment 68522 [details] Patch I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part. Unless someone has evidence that the code is too slow when written that way.

Lucas De Marchi

Comment 4 2010-09-23 11:53:05 PDT

(In reply to comment #3) > (From update of attachment 68522 [details]) > I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part. > > Unless someone has evidence that the code is too slow when written that way. Humn... Yes, I agree. I'll upload a new patch soon.

Lucas De Marchi

Comment 5 2010-09-23 12:06:32 PDT

Created attachment 68559 [details] Patch

WebKit Commit Bot

Comment 6 2010-09-23 15:46:17 PDT

Comment on attachment 68559 [details] Patch Clearing flags on attachment: 68559 Committed r68209: <http://trac.webkit.org/changeset/68209>

WebKit Commit Bot

Comment 7 2010-09-23 15:46:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.