Bug 46347

Summary:

[Qt] Remove setDeviceSize methods

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

ademar, hausmann, kling

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

31552

Attachments:

Description	Flags
Patch	tonikitoo: review+

Kenneth Rohde Christiansen

Reported 2010-09-23 06:37:51 PDT

These methods are not in 2.0 and we do not want them in 2.1. Instead the viewport meta tag stuff should use QDesktopServices to get the device size. device-width is the width of the device when in portrait and the device-height is the width of the device when in landscape. It would be nice to have some environment variables to overwrite the values when testing mobile browsers on the desktop.

Attachments
Patch (8.87 KB, patch) 2010-09-27 10:39 PDT, Kenneth Rohde Christiansen	tonikitoo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kenneth Rohde Christiansen

Comment 1 2010-09-23 06:55:11 PDT

QDesktopWidget should have what we need. We just need to make sure that the geometry gives the actual screen geometry and doesn't subtract things like the cellphone status area.

Kenneth Rohde Christiansen

Comment 2 2010-09-27 10:39:39 PDT

Created attachment 68928 [details] Patch

Kenneth Rohde Christiansen

Comment 3 2010-09-27 17:31:26 PDT

Fixed (after conversation on irc) version landed in r68457

Simon Hausmann

Comment 4 2010-10-05 06:29:16 PDT

<cherry-pick-for-backport: r68457>

Simon Hausmann

Comment 5 2010-10-05 06:29:33 PDT

<cherry-pick-for-backport: r69104>

Ademar Reis

Comment 6 2010-10-06 07:38:11 PDT

Revision r68457 cherry-picked into qtwebkit-2.1 with commit b2d63cf <http://gitorious.org/webkit/qtwebkit/commit/b2d63cf> Revision r69104 cherry-picked into qtwebkit-2.1 with commit 69b269b <http://gitorious.org/webkit/qtwebkit/commit/69b269b>

Note You need to log in before you can comment on or make changes to this bug.