Bug 46333 – commit-queue should log more detailed messages to the QueueStatusServer

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

commit-queue should log more detailed messages to the QueueStatusServer

[Adam Barth]

Created attachment 68493 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 68493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68493&action=review

Looks OK.

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:71
> +        "Applied path",

patch?

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:122
> +        "Unable to pass tests without patch")

Sounds like it might pass fine with it... but don't you dare take the patch away! :p

We could have it include the revision number in these messages.  But that may be a separate patch.

[Adam Barth]

Committed r68117: <http://trac.webkit.org/changeset/68117>

[Mihai Parparita]

(In reply to comment #2)
> We could have it include the revision number in these messages.  But that may be a separate patch.

BTW, it might also be nice to have a way of passing the bot machine name with these messages (or associating it with a patch ID earlier). The grouping on the queue status server gets a bit confused when multiple bots are sending status updates in parallel (we might have to sacrifice strict chronological ordering, or there could be one status list per bot).

[Adam Barth]

Yeah, the page is pretty confusing now.